Retrigger Geo areas in Project edit page #3006
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaKhatri
requested changes
Dec 4, 2024
| value: PartialAdminLevel; | ||
| isPublished?: boolean; | ||
| adminLevelOptions?: AdminLevelType[]; | ||
| onRegionPublishSuccess: () => void; |
Collaborator
There was a problem hiding this comment.
Rename this appropriately
| 'Selected region retrigger successfully', | ||
| { variant: 'success' }, | ||
| ); | ||
| onRegionPublishSuccess(); |
Collaborator
There was a problem hiding this comment.
rename this approriately
| </> | ||
| )} | ||
| > | ||
| {region.status === 'FAILED' && ( |
Collaborator
There was a problem hiding this comment.
Check if the region is already published. If the region is already published this check is not necessary as the user won't/shouldn't be able to retrigger.
| <IoTrashBinOutline /> | ||
| </QuickActionConfirmButton> | ||
| <> | ||
| {region.status === 'FAILED' && ( |
Collaborator
There was a problem hiding this comment.
Check if the region is already published. If the region is already published this check is not necessary as the user won't/shouldn't be able to retrigger.
shreeyash07
force-pushed
the
features/retrigger-regions-geo-area
branch
2 times, most recently
from
3508c34 to
e72147e
Compare
AdityaKhatri
force-pushed
the
features/retrigger-regions-geo-area
branch
from
e72147e to
09cc81e
Compare
AdityaKhatri
approved these changes
Dec 5, 2024
subinasr
approved these changes
Dec 5, 2024
subinasr
force-pushed
the
features/retrigger-regions-geo-area
branch
from
09cc81e to
4b9da3c
Compare
AdityaKhatri
force-pushed
the
features/retrigger-regions-geo-area
branch
from
4b9da3c to
5ca9c26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR doesn't introduce any:
console.logmeant for debuggingThis PR contains valid: