Skip to content

Conversation

@barshathakuri
Copy link
Collaborator

@barshathakuri barshathakuri commented Jan 21, 2025

Changes

  • Remove zendesk code
  • Add monday feedback in place of zendesk for bug and feedback

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • build works
  • eslint issues
  • typescript issues
  • codegen errors
  • console.log meant for debugging
  • typos
  • unwanted comments
  • conflict markers

This PR contains valid:

  • permission checks
  • translations

}

function Base() {
const [mondayFormVisible, setMondayFormVisible] = useState(false);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use useModalState

@barshathakuri barshathakuri force-pushed the feature/integrate-monday-feedback branch from e7994a2 to beb5c82 Compare January 22, 2025 11:06
@barshathakuri barshathakuri marked this pull request as ready for review January 22, 2025 11:11
<div className={styles.formContent}>
<div className={styles.formTopBar}>
<p>Leave us a message</p>
<Button
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use QuickActionButton

className={styles.zendeskHelpButton}
onClick={openZendeskFeedback}
onClick={openMondayForm}
type="button"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not necessary

Comment on lines 232 to 239
const openMondayForm = () => {
setMondayFormVisible();
};

const closeMondayForm = () => {
setMondayFormHidden();
};

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not necessary and can be used directly

@barshathakuri barshathakuri force-pushed the feature/integrate-monday-feedback branch from beb5c82 to 99e17b9 Compare January 23, 2025 08:16
@AdityaKhatri AdityaKhatri merged commit 500ff21 into develop Jan 23, 2025
5 checks passed
@AdityaKhatri AdityaKhatri deleted the feature/integrate-monday-feedback branch January 23, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants