Skip to content

Conversation

@sudan45
Copy link
Collaborator

@sudan45 sudan45 commented Mar 5, 2024

Addresses

Changes

  • soft delete of widget

Mention related users here if any.

This PR doesn't introduce any:

  • temporary files, auto-generated files or secret keys
  • n+1 queries
  • flake8 issues
  • print
  • typos
  • unwanted comments

This PR contains valid:

  • tests
  • permission checks (tests here too)
  • translations

@sudan45 sudan45 self-assigned this Mar 5, 2024
@sudan45 sudan45 requested a review from thenav56 March 15, 2024 05:34
Copy link
Collaborator

@Rup-Narayan-Rajbanshi Rup-Narayan-Rajbanshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a small change.

)
qs.delete()
qs.update(is_deleted=True)
# qs.delete()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets remove this comment line.

@sudan45 sudan45 assigned AdityaKhatri and subinasr and unassigned sudan45 May 2, 2024
@sudan45 sudan45 force-pushed the fix/af_export branch 2 times, most recently from a965a0d to dfcb9c5 Compare May 7, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants