Skip to content

Fixed modules/sb/fsw/src/cfe_sb_api.c, modules/fs/ut-coverage/fs_UT.c… #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
myc-yang wants to merge 1 commit into
base: draco_update
Choose a base branch
from
Draft

Fixed modules/sb/fsw/src/cfe_sb_api.c, modules/fs/ut-coverage/fs_UT.c… #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/es/ut-coverage/es_UT.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4495,7 +4495,7 @@ void TestAPI(void)

/* Force a vsnprintf failure */
ES_ResetUnitTest();
UtAssert_VOIDCALL(ES_UT_SysLog_snprintf(SysLogBuf, sizeof(SysLogBuf), NULL));
UtAssert_VOIDCALL(ES_UT_SysLog_snprintf(SysLogBuf, sizeof(SysLogBuf), ""));

/* Test run loop with an application error status */
ES_ResetUnitTest();
Expand Down
2 changes: 1 addition & 1 deletion modules/fs/ut-coverage/fs_UT.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ void Test_CFE_FS_ParseInputFileNameEx(void)
UtAssert_INT32_EQ(
CFE_FS_ParseInputFileNameEx(OutBuffer, "", sizeof(OutBuffer), 10, NULL, NULL, TEST_DEFAULT_EXTENSION),
CFE_FS_INVALID_PATH);
UtAssert_INT32_EQ(CFE_FS_ParseInputFileNameEx(OutBuffer, "/path/", sizeof(OutBuffer), 10, NULL, TEST_DEFAULT_PATH,
UtAssert_INT32_EQ(CFE_FS_ParseInputFileNameEx(OutBuffer, "/path/", sizeof(OutBuffer), sizeof("/path/"), NULL, TEST_DEFAULT_PATH,
TEST_DEFAULT_EXTENSION),
CFE_FS_INVALID_PATH);

Expand Down
5 changes: 2 additions & 3 deletions modules/sb/fsw/src/cfe_sb_api.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1926,16 +1926,15 @@ CFE_Status_t CFE_SB_ReceiveBuffer(CFE_SB_Buffer_t **BufPtr, CFE_SB_PipeId_t Pipe
{
--PipeDscPtr->CurrentQueueDepth;
}
/* Should decrement the use count only if buffer is within bounds of allocated memory, for the ref that was in the queue */
CFE_SB_DecrBufUseCnt(BufDscPtr);
}
else
{
/* should send the bad pipe ID event here too */
PendingEventID = CFE_SB_BAD_PIPEID_EID;
Status = CFE_SB_PIPE_RD_ERR;
}

/* Always decrement the use count, for the ref that was in the queue */
CFE_SB_DecrBufUseCnt(BufDscPtr);
}

/* Before unlocking, increment relevant error counter if needed */
Expand Down