fix(windows): prevent libuv assertion failure in smart-install.js #474
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, using `shell: true` with spawnSync can cause: - DEP0190 deprecation warnings about unescaped arguments - libuv assertion failures (UV_HANDLE_CLOSING race condition) This fix introduces a `needsShell()` helper that: - Returns false for absolute paths (no shell needed for .exe files) - Returns true only for bare command names requiring PATH resolution - Always returns false on non-Windows platforms Changes: - Prioritize checking common installation paths before PATH resolution - Use spawnSync with shell: false when full executable path is available - Add `isAbsolute` import from 'path' module - Update all spawn/exec calls to use needsShell() helper Tested on Windows 11 with Bun 1.3.5 - no assertion failures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UV_HANDLE_CLOSING) that occurs during session startupshell: trueneedsShell()helper to intelligently determine when shell is requiredProblem
On Windows, using
shell: truewithspawnSynccauses:Assertion failed: !(handle->flags & UV_HANDLE_CLOSING), file src\win\async.c, line 76[DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilitiesSolution
~/.bun/bin/bun.exe) before PATH resolutionshell: truewhen running bare command names that require PATH resolutionTest plan
bun installruns without errors🤖 Generated with Claude Code