fix: disable minifyIdentifiers to prevent variable name collisions #537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes thedotmack#536 and thedotmack#535 The esbuild minifier was reusing variable names across nested scopes, causing a "has already been declared" error in the built worker-service.cjs. The issue occurred in `getFilesForSession` where the minifier assigned: - Line 360: `let a=this.db.prepare(...)` - Line 364: `a=new Set` This caused Bun to error with "'a' has already been declared". The fix adds `minifyIdentifiers: false` to all CJS builds (worker-service, mcp-server, context-generator) to preserve unique variable names while still minifying whitespace and syntax. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #536 and #535
The esbuild minifier was reusing variable names across nested scopes, causing a runtime error in the built
worker-service.cjs:Root Cause
In
getFilesForSession, the minifier assigned the same variable nameato both:let a=this.db.prepare(...)a=new SetThis caused Bun to error because the variable was redeclared in the same scope.
Solution
Added
minifyIdentifiers: falseto the esbuild configuration for all CJS builds:worker-service.cjsmcp-server.cjscontext-generator.cjsThis preserves unique variable names while still minifying whitespace and syntax. The file size increase is minimal (~10-15KB) but prevents this class of minification bugs.
Verification
After applying the fix, the built file shows proper variable separation:
let n=this.db.prepare(...)(nown)a=new Set(stilla, no collision)Test plan
npm run buildsucceedsworker-service.cjsno longer has variable collision🤖 Generated with Claude Code