fix: generate memorySessionId for stateless providers #615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenRouter/Gemini APIs don't return session IDs. Generate synthetic IDs to satisfy FK constraint.
- Add setting to SettingsDefaults interface and defaults (false) - Add to settingKeys and booleanSettings arrays in SettingsRoutes - Add early return check in updateFolderClaudeMdFiles() Folder CLAUDE.md generation now disabled by default. Equivalent to PR thedotmack#672.
|
LGTM... @thedotmack can approve? |
RPirruccio
added a commit
to RPirruccio/claude-mem
that referenced
this pull request
Jan 17, 2026
…r, Gemini)
OpenRouter and Gemini are stateless APIs that do not return session IDs.
This causes a race condition where hooks fire before memorySessionId is set,
leading to NULL foreign keys and crash loops.
Generate synthetic IDs immediately after API key validation to ensure
memorySessionId is always available before any database operations.
Pattern: {provider}-{contentSessionId}-{timestamp}
Fixes the root cause of issue thedotmack#591 and implements PR thedotmack#615 approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
OpenRouter/Gemini APIs are stateless—they don't return session IDs. This breaks the FK constraint, causing observations to fail silently.
Fixes #591
Fix
Generate synthetic memorySessionId before first API call. 21 lines across 3 files.
Testing
MEMORY_ID_GENERATEDin logs