fix: Reset AbortController before starting generator to prevent infinite abort loop #627
+10
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Sessions can get stuck in an infinite "Generator aborted" loop, preventing any observation processing.
Root Cause
When a generator exits with
wasAborted=true, the cleanup instartGeneratorWithProvider()correctly sets:generatorPromise = null✓currentProvider = null✓But it does NOT reset the
AbortController, leavingsignal.aborted = true.When new observations arrive:
ensureGeneratorRunning()seesgeneratorPromise = nullstartGeneratorWithProvider()signal.aborted = trueReproduction
Solution
Add a check at the beginning of
startGeneratorWithProvider()to detect if the session's AbortController signal is already aborted. If so, create a fresh AbortController instance before proceeding.This mirrors the existing crash recovery logic (line 192) but applies it universally to all generator starts.
Testing
Impact
Low risk - only affects sessions that were previously stuck. Normal session flow unchanged.