Fix/worker port configuration #631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MCP server had hardcoded version '1.0.0' instead of using the build-time injected __DEFAULT_PACKAGE_VERSION__. This caused version-consistency.test.ts to fail. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Tests using mock.module() to mock the logger singleton were polluting subsequent tests. The logger-format-tool.test.ts tests failed because they received the mocked logger instead of the real one. Changes: - Export Logger class to allow creating fresh instances - Use fresh Logger instance in formatTool tests - Add formatTool to logger mocks for complete interface 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
… > defaults) Environment variable CLAUDE_MEM_WORKER_PORT was ignored when loading settings. Port remained at 37777 regardless of configuration. Root Cause: SettingsDefaultsManager.loadFromFile() only read from settings file, completely bypassing environment variables. Changes: - Added applyEnvOverrides() helper method to SettingsDefaultsManager - Applied env var overrides in all code paths (normal, file-not-exist, error) - Fixed hardcoded port 37777 in utility scripts to use settings Configuration Priority (Now Working): 1. process.env.CLAUDE_MEM_WORKER_PORT ← highest 2. ~/.claude-mem/settings.json 3. 37777 (default) ← lowest Scripts Fixed: - scripts/check-pending-queue.ts - scripts/clear-failed-queue.ts - scripts/sync-marketplace.cjs - ragtime/ragtime.ts Fixes thedotmack#185 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
…nt variables Extends the configuration priority fix from a4800359 to cover all settings. Previously, DATA_DIR and WORKER_HOST were hardcoded in many locations, ignoring user configuration via environment variables or settings file. Changes: - paths.ts: DATA_DIR now checks process.env first (settings file cannot override due to circular dependency - settings file is IN the data dir) - All hooks and services now use getWorkerHost() instead of hardcoded 127.0.0.1 - Consolidated 20+ hardcoded path constructions to use centralized paths.ts - Settings path resolution now respects DATA_DIR configuration Configuration Priority (Now Working for All Settings): 1. process.env.CLAUDE_MEM_* (highest) 2. ~/.claude-mem/settings.json 3. Default values (lowest) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Author
|
Will rebase and open a new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes configuration priority handling throughout the codebase, ensuring environment variables properly override file-based settings and defaults. It also includes fixes for test pollution and build-time version injection.
Key changes:
CLAUDE_MEM_WORKER_PORT,CLAUDE_MEM_DATA_DIR,CLAUDE_MEM_WORKER_HOST) now consistently take priority over settings file valuespaths.ts127.0.0.1references withgetWorkerHost()across all hooks and servicesmock.module()affecting logger testsConfiguration priority (now working consistently):
process.env.CLAUDE_MEM_*(highest)~/.claude-mem/settings.jsonFixes #185
Test plan
CLAUDE_MEM_WORKER_PORT=9999 claude-mem startuses port 9999CLAUDE_MEM_DATA_DIR=/tmp/test claude-mem startuses custom data directoryCLAUDE_MEM_WORKER_HOST=0.0.0.0 claude-mem startbinds to all interfacesnpm test🤖 Generated with Claude Code