Skip to content

Stop using git.sr.ht/~spc/go-log and use copy on github.com#24

Merged
adamruzicka merged 6 commits intotheforeman:mainfrom
adamruzicka:build
Apr 30, 2025
Merged

Stop using git.sr.ht/~spc/go-log and use copy on github.com#24
adamruzicka merged 6 commits intotheforeman:mainfrom
adamruzicka:build

Conversation

@adamruzicka
Copy link
Copy Markdown
Contributor

@adamruzicka adamruzicka commented Apr 29, 2025

Copy link
Copy Markdown

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some suggestion. Otherwise, it looks OK.

Comment thread go.mod Outdated
)

require (
git.sr.ht/~spc/go-log v0.1.1 // indirect
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seems as correct change. This "old" go module should not be required indirectly. If it was required indirectly, then it would cause problems anyway. I guess that you also have to update version of yggdrasil, where git.sr.ht/~spc/go-log v0.1.1 is not required.

aka 477928891fab4f542da9733215206bf77527643f
@Odilhao
Copy link
Copy Markdown
Member

Odilhao commented Apr 29, 2025

@ehelms should we still keep EL7 here?

@Odilhao
Copy link
Copy Markdown
Member

Odilhao commented Apr 29, 2025

For RHEL7 we need to update

https://github.com/theforeman/foreman-packaging/blob/66016f546d8c324a0049b18604bd4253ffbdf7b4/packages/client/foreman_ygg_worker/foreman_ygg_worker.spec#L46

To

%if 0%{?rhel} >= 8 || 0%{?fedora}
Requires: (yggdrasil >= 0.2 with yggdrasil < 0.5)
%else
Requires: yggdrasil >= 0.2
Requires: yggdrasil < 0.5
%endif

@adamruzicka
Copy link
Copy Markdown
Contributor Author

I totally forgot we dropped support for el7 clients in f-packaging, that's why the spec uses only 8+ features. Guess we should follow suit and drop it from here as well?

@Odilhao
Copy link
Copy Markdown
Member

Odilhao commented Apr 29, 2025

Since it's not present on f-clients anymore, feel free to drop the EL7 packit.

@adamruzicka
Copy link
Copy Markdown
Contributor Author

🍏

Copy link
Copy Markdown

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamruzicka adamruzicka merged commit 5be8543 into theforeman:main Apr 30, 2025
5 checks passed
@adamruzicka adamruzicka deleted the build branch April 30, 2025 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants