Stop using git.sr.ht/~spc/go-log and use copy on github.com#24
Merged
adamruzicka merged 6 commits intotheforeman:mainfrom Apr 30, 2025
Merged
Stop using git.sr.ht/~spc/go-log and use copy on github.com#24adamruzicka merged 6 commits intotheforeman:mainfrom
adamruzicka merged 6 commits intotheforeman:mainfrom
Conversation
jirihnidek
suggested changes
Apr 29, 2025
jirihnidek
left a comment
There was a problem hiding this comment.
I have some suggestion. Otherwise, it looks OK.
| ) | ||
|
|
||
| require ( | ||
| git.sr.ht/~spc/go-log v0.1.1 // indirect |
There was a problem hiding this comment.
This does not seems as correct change. This "old" go module should not be required indirectly. If it was required indirectly, then it would cause problems anyway. I guess that you also have to update version of yggdrasil, where git.sr.ht/~spc/go-log v0.1.1 is not required.
aka 477928891fab4f542da9733215206bf77527643f
Member
|
@ehelms should we still keep EL7 here? |
Member
|
For RHEL7 we need to update To |
Contributor
Author
|
I totally forgot we dropped support for el7 clients in f-packaging, that's why the spec uses only 8+ features. Guess we should follow suit and drop it from here as well? |
Member
|
Since it's not present on f-clients anymore, feel free to drop the EL7 packit. |
Contributor
Author
|
🍏 |
Odilhao
approved these changes
Apr 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO: