Adding support for jsoniter scala#531
Open
jkozlovvski wants to merge 16 commits intomasterfrom
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces a new kebs-jsoniter module intended to provide automatic jsoniter-scala codec generation for Kebs types across Scala 2.13 and Scala 3, and wires the module into the multi-project build.
Changes:
- Adds a new
jsonitercrossProject, including jsoniter-scala dependencies and aggregation into the root build. - Implements jsoniter codec derivation for Kebs types (value classes / instance converters), with Scala 2 & Scala 3 source sets.
- Adds a jsoniter test suite + version-specific test models; also adds Metals-generated
metals.sbtplugin files.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 13 comments.
Show a summary per file
| File | Description |
|---|---|
build.sbt |
Adds jsoniter-scala deps/settings and a new jsoniterSupport crossProject; changes default Scala version and aggregates jsoniter modules. |
project/metals.sbt |
Adds sbt-bloop plugin via Metals-generated file. |
project/project/metals.sbt |
Adds sbt-bloop plugin via Metals-generated file (nested meta-build). |
project/project/project/metals.sbt |
Adds sbt-bloop plugin via Metals-generated file (deeply nested meta-build). |
jsoniter/src/main/scala-2/pl/iterators/kebs/jsoniter/KebsJsoniter.scala |
Scala 2 macro-based codec derivation for Kebs types and fallback derivation. |
jsoniter/src/main/scala-3/pl/iterators/kebs/jsoniter/KebsJsoniter.scala |
Scala 3 inline-based codec derivation, plus snakified/capitalized variants. |
jsoniter/src/main/scala/pl/iterators/kebs/jsoniter/package.scala |
Attempts to expose a package object-based entrypoint for jsoniter support. |
jsoniter/src/main/scala/pl/iterators/kebs/jsoniter/enums/package.scala |
Placeholder (commented) enums package object. |
jsoniter/src/main/scala/pl/iterators/kebs/jsoniter/enums/KebsJsoniterEnums.scala |
Placeholder (commented) enums/value-enums codec implementation. |
jsoniter/src/test/scala/pl/iterators/kebs/jsoniter/formats/JsoniterFormatTests.scala |
Base jsoniter codec tests (flat, DTO, recursive, >22 fields). |
jsoniter/src/test/scala/pl/iterators/kebs/jsoniter/formats/JsoniterFormatSnakifiedVariantTests.scala |
Tests for snake_case variant codec behavior. |
jsoniter/src/test/scala/pl/iterators/kebs/jsoniter/formats/JsoniterFormatCapitalizeVariantTests.scala |
Tests for PascalCase/capitalized variant codec behavior. |
jsoniter/src/test/scala-2/pl/iterators/kebs/jsoniter/model/model.scala |
Scala 2 test model definitions. |
jsoniter/src/test/scala-2/pl/iterators/kebs/jsoniter/KebsEnumForTests.scala |
Scala 2 test helper trait for enumeratum enums. |
jsoniter/src/test/scala-2/pl/iterators/kebs/jsoniter/KebsValueEnumForTests.scala |
Scala 2 test helper trait for enumeratum value enums. |
jsoniter/src/test/scala-3/pl/iterators/kebs/jsoniter/model/model.scala |
Scala 3 test model definitions (Scala 3 enums/value enums). |
jsoniter/src/test/scala-3/pl/iterators/kebs/jsoniter/KebsEnumForTests.scala |
Scala 3 test helper trait for Kebs enums. |
jsoniter/src/test/scala-3/pl/iterators/kebs/jsoniter/KebsValueEnumForTests.scala |
Scala 3 test helper trait for Kebs value enums. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
added 10 commits
April 2, 2026 12:10
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 21 out of 22 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
luksow
reviewed
Apr 13, 2026
| @@ -0,0 +1,8 @@ | |||
| // format: off | |||
luksow
reviewed
Apr 13, 2026
| @@ -0,0 +1,8 @@ | |||
| // format: off | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.