Move all theme colors to colors section #204
Conversation
All theme colors should be in Colors section for less user confusion.
| { | ||
| 'key': 'ARC_TRANSPARENCY', | ||
| 'type': 'bool', | ||
| 'fallback_value': True, | ||
| 'display_name': _('Enable GTK3 Theme Transparency'), | ||
| 'display_name': _('Enable Theme Transparency'), |
There was a problem hiding this comment.
did they modified Arch theme what now it supports setting border colors and transparency outside gtk3?
if not — then renaming those could be misleading since people will be creating tickets why the setting didn't applied to their gtk2 or xfce theme
There was a problem hiding this comment.
This transparency setting is already available on gnome-shell as well. For example:
There was a problem hiding this comment.
Regarding the border color: At least $button_border is used in gnome-shell theme.
UPD: Actually $entry_border is also used in gnome-shell and cinnamon.
Off-topic: I didn't carefully check, and I thought $borders_color also has the ARC_WIDGET_BORDER_COLOR var, but it was wrong... Is that intentional?
There was a problem hiding this comment.
it should be used for both entry and button borders, so you found a bug in theme template :-)
so this change can be accepted in this case
still i would like to discuss what could be a good way to report in theme options list what some options available/unavailable in some specific desktop environments or toolkits
There was a problem hiding this comment.
ah, i found the button border, it seems fine: https://github.com/NicoHood/arc-theme/blob/master/common/gtk-3.0/_colors.scss.thpl#L85
There was a problem hiding this comment.
information-symbol -- exactly what should fit the case
There was a problem hiding this comment.
asterisk could benefit as being less visual noisy, though it could be unclear
There was a problem hiding this comment.
or warning icon with tooltip text not supported by GTK+2 theme
There was a problem hiding this comment.
also, should such tooltip happen on hover or on click?
There was a problem hiding this comment.
or warning icon with tooltip text not supported by GTK+2 theme
That would be the best 👍
also, should such tooltip happen on hover or on click?
+1 for on hover :)
| @@ -99,6 +99,21 @@ class Plugin(OomoxThemePlugin): | |||
| 'GTK3_GENERATE_DARK', | |||
| ] | |||
|
|
|||
| theme_model_gtk = [ | |||
There was a problem hiding this comment.
i think for caret will be better to just create its own sub-section named "Text Input Caret" (under section "Theme", like in Oomox-gtk-theme it's currently done for GTK3-only options) after theme options will be splitted by StackSwitcher into main sections (Theme/Icons/Terminal/Other)
as i can judge from the mockups of settings screens and incorporating into textstyle recommendations (to avoid repeating labels and prefer grouping of those items instead) i think splitting theme options into smaller sub-section could make sense
There was a problem hiding this comment.
Personally I feel pretty strange that some color options are not in the Colors section.
What about moving "Caret Aspect Ratio" into the "Advanced Options" section as my latest mockup instead of that?
There was a problem hiding this comment.
i think rather than having some hardcoded options i think it would make sense to group some specific options, for example gtk3-only or caret-specific
but specifically with caret my main motivation -- i really tired of questions what the "caret" is, and when it's under its own section there it's written "Text Input Caret" it's at least giving a hint what the caret is and allows also to avoid repetitive "prefix" "Text Input Caret ..." in options names
idk, mb try to come up with shorter but cleaner labels to solve the issue i've illustrated above, mb "Text Caret 1", "Text Caret 2" in colors section and "Text Caret Aspect Ratio" in other options and also put caret color options close to textbox color options
There was a problem hiding this comment.
or even Text Cursor instead of Text Caret
There was a problem hiding this comment.
As another option: What do you think about removing those "caret" options from Oomox theme? To be honest, I think those "caret" options are pretty niche. Even me, I don't know how meaningful/effective it is to change the "Caret Aspect Ratio". I think majority people don't understand what they are, while only quite a few people may need those options. (This is why I moved "Caret Aspect Ratio" into the "Advanced Options" section in my mockup...)
There was a problem hiding this comment.
Textbox Caret, BiDi Textbox Caret, and Textbox Caret Aspect Ratio?
Hmm, I personally feel Text Caret sounds more natural and enough, though I'm not good at English...
There was a problem hiding this comment.
why does Bi-Directional caret require separate styling from a primary one?
There was a problem hiding this comment.
everyday you learn something new :-)
i don't have strong preference towards text/textbox but it just seems more inline with 'textbox text' and 'textbox background'
There was a problem hiding this comment.
or just leave caret related stuff to live in it's own section below other gtk options, as now :)
There was a problem hiding this comment.
Renamed Caret options.
or just leave caret related stuff to live in it's own section below other gtk options, as now :)
One of my motivations of this PR is to make comparisons with other colors easier. In the current GUI, long scrolling is required when you want to compare Caret colors with other colors. That's a bit less accessible, especially when you want to sync the caret colors with other colors.
|
thanks! |
All theme colors should be in Colors section for less user confusion.