Skip to content

feature/reader-dbi-parameter-group #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
petlitskiy wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feature/reader-dbi-parameter-group #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8083e42
Conditions
petlitskiy Nov 19, 2025
1054311
Update aurora-mysql.cfndsl.rb
petlitskiy Nov 19, 2025
a9844ac
Update conditions and parameter fetching in CFN DSL
petlitskiy Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions aurora-mysql.cfhighlander.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
ComponentParam 'StorageType', 'aurora', allowedValues: ['aurora', 'aurora-iopt1']
ComponentParam 'EnableHttpEndpoint', 'false', allowedValues: ['true', 'false']
ComponentParam 'EnableReader', 'false'
ComponentParam 'ReaderOwnParameterGroup', 'false'
ComponentParam 'ReaderPromotionTier', 1, allowedValues: [0,1,2,3,4,5,6,7,8,9,10,11,12,13,14,15]
ComponentParam 'BacktrackWindow', 0

Expand Down
15 changes: 11 additions & 4 deletions aurora-mysql.cfndsl.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
Condition("EnableCloudwatchLogsExports", FnNot(FnEquals(Ref(:EnableCloudwatchLogsExports), '')))
Condition("EnableLocalWriteForwarding", FnEquals(Ref(:EnableLocalWriteForwarding), 'true'))
Condition("EnableReader", FnEquals(Ref(:EnableReader), 'true'))
Condition("EnableReaderOwnParameterGroup", FnAnd([FnEquals(Ref(:ReaderOwnParameterGroup), 'true'), FnEquals(Ref(:EnableReader), 'true')]))

Condition("IsWriterServerless", FnEquals(Ref(:WriterInstanceType), 'db.serverless'))
Output('IsWriterServerless') {
Expand Down Expand Up @@ -92,11 +93,17 @@
RDS_DBParameterGroup(:DBInstanceParameterGroup) {
Description FnJoin(' ', [ Ref(:EnvironmentName), external_parameters[:component_name], 'instance parameter group' ])
Family external_parameters[:family]
Parameters external_parameters[:instance_parameters]
Parameters external_parameters.fetch(:instance_parameters, {})
Tags tags + [{ Key: 'Name', Value: FnJoin('-', [ Ref(:EnvironmentName), external_parameters[:component_name], 'instance-parameter-group' ])}]
}


RDS_DBParameterGroup(:DBReaderInstanceParameterGroup) {
Condition(:EnableReaderOwnParameterGroup)
Description FnJoin(' ', [ Ref(:EnvironmentName), external_parameters[:component_name], 'reader instance parameter group' ])
Family external_parameters[:family]
Parameters external_parameters.fetch(:reader_instance_parameters, {})
Tags tags + [{ Key: 'Name', Value: FnJoin('-', [ Ref(:EnvironmentName), external_parameters[:component_name], 'reader-instance-parameter-group' ])}]
}

RDS_DBCluster(:DBCluster) {
Engine external_parameters[:engine]
Expand Down Expand Up @@ -153,7 +160,7 @@
RDS_DBInstance(:ServerlessDBInstanceReader) {
Condition(:EnableReader)
DBSubnetGroupName Ref(:DBClusterSubnetGroup)
DBParameterGroupName Ref(:DBInstanceParameterGroup)
DBParameterGroupName FnIf(:EnableReaderOwnParameterGroup, Ref(:DBReaderInstanceParameterGroup), Ref(:DBInstanceParameterGroup))
Engine external_parameters[:engine]
DBClusterIdentifier Ref(:DBCluster)
AutoMinorVersionUpgrade minor_upgrade unless minor_upgrade.nil?
Expand Down Expand Up @@ -181,7 +188,7 @@
RDS_DBInstance(:DBClusterInstanceReader) {
Condition(:EnableReader)
DBSubnetGroupName Ref(:DBClusterSubnetGroup)
DBParameterGroupName Ref(:DBInstanceParameterGroup)
DBParameterGroupName FnIf(:EnableReaderOwnParameterGroup, Ref(:DBReaderInstanceParameterGroup), Ref(:DBInstanceParameterGroup))
Engine external_parameters[:engine]
DBClusterIdentifier Ref(:DBCluster)
AutoMinorVersionUpgrade minor_upgrade unless minor_upgrade.nil?
Expand Down