Skip to content

Retain S3-backed origin#15

Merged
aaronwalker merged 3 commits intotheonestack:masterfrom
petlitskiy:BN-3784
May 21, 2025
Merged

Retain S3-backed origin#15
aaronwalker merged 3 commits intotheonestack:masterfrom
petlitskiy:BN-3784

Conversation

@petlitskiy
Copy link
Contributor

In accordance with Jira BN-3784

@petlitskiy
Copy link
Contributor Author

Checked with cfhighlander cftest --no-validate

@aaronwalker
Copy link
Member

@petlitskiy FYI I'm getting this error when I run the tests

cfndsl template for cloudfront written to /workspace/hl-component-s3-cloudfront/out/cfndsl/cloudfront.compiled.cfndsl.rb
/workspace/hl-component-s3-cloudfront/out/cfndsl/cloudfront.compiled.cfndsl.rb:38:in `block in eval_file_with_extras': undefined local variable or method `origins' for #<CfnDsl::CloudFormationTemplate:0x00007fa404414920 @AWSTemplateFormatVersion="2010-09-09"> (NameError)
Did you mean?  vpcOrigin
        from /home/gitpod/.rvm/gems/ruby-3.2.8/gems/cfndsl-1.7.2/lib/cfndsl/jsonable.rb:164:in `instance_eval'
        from /home/gitpod/.rvm/gems/ruby-3.2.8/gems/cfndsl-1.7.2/lib/cfndsl/jsonable.rb:164:in `declare'
        from /home/gitpod/.rvm/gems/ruby-3.2.8/gems/cfndsl-1.7.2/lib/cfndsl/cloudformation.rb:114:in `CloudFormation'
        from /workspace/hl-component-s3-cloudfront/out/cfndsl/cloudfront.compiled.cfndsl.rb:6:in `eval_file_with_extras'
        ````
        
I'll do some digging       

Copy link
Member

@aaronwalker aaronwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed fix

@aaronwalker aaronwalker merged commit 50951c2 into theonestack:master May 21, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants