Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: creator edges #440

Merged
merged 1 commit into from
Feb 5, 2025
Merged

feat: creator edges #440

merged 1 commit into from
Feb 5, 2025

Conversation

golanglemonade
Copy link
Member

@golanglemonade golanglemonade commented Feb 4, 2025 •
edited
Loading

  • removes the back-ref edges from groups -> organization for the creator edges. This is a 1:M not many:many (meaning the group can only be used to assign creator permissions to one organization, not many, so the back-ref was always just the organization that owned the group
  • adds tests to ensure only org editors (admins) can add these permissions

Merge before #432

@golanglemonade golanglemonade marked this pull request as ready for review February 4, 2025 21:09
@golanglemonade golanglemonade requested a review from a team as a code owner February 4, 2025 21:09
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.4% Coverage on New Code (required ≥ 20%)

See analysis details on SonarQube Cloud

@golanglemonade golanglemonade enabled auto-merge (squash) February 4, 2025 21:21
@golanglemonade golanglemonade mentioned this pull request Feb 5, 2025
Merged
@golanglemonade golanglemonade merged commit f4529dc into main Feb 5, 2025
16 of 17 checks passed
@golanglemonade golanglemonade deleted the feat-creator-perm branch February 5, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matoszz matoszz matoszz approved these changes

@LemonAid711 LemonAid711 Awaiting requested review from LemonAid711 LemonAid711 is a code owner automatically assigned from theopenlane/blacksmiths

@theopenlane-bender theopenlane-bender Awaiting requested review from theopenlane-bender theopenlane-bender is a code owner automatically assigned from theopenlane/blacksmiths

Assignees
No one assigned
Labels
codegenerators coreclient dbschema enhancement New feature or request graphapi graphqlschema migrations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@golanglemonade @matoszz