refactor to use options pattern throughout #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
nice! I think we should try to use this in core before we merge, because we have a lot of code that uses the httpsling.Client which is removed here so we need to make sure there is 1:1 functionality, at first pass it looks like we might be missing some pieces that we depend on today.
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
Signed-off-by: Sarah Funkhouser <[email protected]>
|
golanglemonade
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a wholesale refactor, changing all of the request / response / "do" functions to use options patterns and self-referencing functions