Switch plan(int) to plan(bigint) #348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A useful test pattern is to define a matrix of tests in a table or view by building a cartesian join of multiple dimensions. If you do that, you'll want to do something along the lines of SELECT plan( 0 + <some number of static tests> + (SELECT count(*) FROM test_view) ); Because count(*) returns bigint doing this with plan(int) forces you to cast the output of count(*) to int. Switching plan() to accept a bigint removes the need for that cast.
|
@theory shouldn't this PR have kicked off an automated test run? |
|
It would have if you didn't keep changing your damn GitHub account name, @jnasbyupgrade! Is this who you are now? Currently the collaborators are: 
|
theory
requested changes
Apr 18, 2025
|
Ahh, didn't realize tests were limited to contributors. You can remove nasbyj since I no longer work at Amazon. This is my new work account. I can also just do things from my personal account if you'd rather that. |
|
Whichever you prefer. Maybe if @jnasbyupgrade is another work account it should be your personal account? @decibel already had the permissions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A useful test pattern is to define a matrix of tests in a table or view by building a cartesian join of multiple dimensions. If you do that, you'll want to do something along the lines of
SELECT plan(
0
Because count() returns bigint doing this with plan(int) forces you to cast the output of count() to int. Switching plan() to accept a bigint removes the need for that cast.