WIP: Add procedures are()
#359
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And add doc for `procedures_are()`
copy pasted with minor edition from `functions_are()`
It is now excluding procedures from the list of functions. See `procedures_are()` instead.
c2main
force-pushed
the
add-procedures_are
branch
from
ce21421 to
2dcd43b
Compare
|
Thank you! |
theory
requested changes
Sep 6, 2025
| @@ -4979,7 +4979,7 @@ RETURNS TEXT AS $$ | |||
| SELECT _are( | |||
| 'functions', | |||
| ARRAY( | |||
| SELECT name FROM tap_funky WHERE schema = $1 | |||
| SELECT name FROM tap_funky WHERE schema = $1 and kind != 'p' | |||
There was a problem hiding this comment.
What do we do about people who have used these functions for procedures? With this change, their tests will start failing.
I wonder if maybe we should introduce a warning with a deprecation notice and instructions for them to update their tests when kind = 'p', and then remove it in a year or so.
There was a problem hiding this comment.
The migration file is missing the changes to the functions_are() functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code, test and doc overall ok, though there are some other references to functions_are() that I didn't explore yet.