Skip to content

Fix sanitizer function for libxml2 >= 2.14 and HTML5 #264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix sanitizer function for libxml2 >= 2.14 and HTML5 #264

wants to merge 1 commit into from

Conversation

renanrodrigo
Copy link

This is adapting the sanitize function to remove commented XML tags from the resulting markdown.
Fixes: #263

@renanrodrigo
Fix sanitizer function for libxml2 >= 2.14 and HTML5
66416e0 
This is adapting the sanitize function to remove commented XML tags from
the resulting markdown.
Fixes: thephpleague#263
@renanrodrigo
Copy link
Author

renanrodrigo commented Aug 7, 2025 •
edited
Loading

Bear in mind that this change to the sanitize function is addressing the errors found in #263 , but it doesn´t cover other errors which may happen due to the libxml2 changes to loadHTML.
Maybe a proper fix for the future would be considering, at least for php8.4, changing DOMDocument for DOM\HTMLDocument, which conforms to HTML5 and considers UTF-8 by default?
Curious to see how this evolves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem when converting HTML strings when php is compiled with the new libxml2 (2.14)
1 participant
@renanrodrigo