Focus mode + Role management #290
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This starts the work in setting up a focus mode interaction in Valkyrie.
This sets correct button states whether focus mode is enabled / disabled.
WIP - Just changing message events for testing on test-valkyrie instance.
- Resolve issues from lint
This commit adds a basic role manager linked to test-valkyrie instance for now, to easily assign focus roles on and off based on button interactions.
Shadowfiend
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Just a naming note—if we want a subdir, we should have role-management/index.ts, think about the subdirectory as a “module”, and what index.ts exports should be the external-facing (i.e. for any other directory including parents) API of the directory. No one else should import role-management/*, they should just import role-management or role-management/index.ts (Those two should be synonyms.)
Change `role-management.ts` to `index.ts`
This commit fixes the issue on runtime, so now the focusmode message is sent as soon as the `discordClient` can confirm there is a channel named `verify`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This adds a
focus-modecontroller to Valkyrie which allows discord users to set their roles tofocus, which will temporarily hide specific discord channels until the focus mode is disabled. In addition, it also addsrole-managementcomponent to easily be able to remove/add roles based on a discorduserIDandroleID.Screenshots
To-do
focus-mode.tscontroller that spawns message event in channel