Role management #294
Open
Role management #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a `role-management` to Valkyrie which allows you to call the function on another script to add/remove roles based on the following criteria: - guildID (Discord server ID) - memberID (Discord user ID) - roleID (Discord role ID) - action (add or remove)
|
Marking this one as ready to review, so we can merge and built out additional features discussed. |
Shadowfiend
requested changes
Mar 11, 2024
| @@ -0,0 +1,34 @@ | |||
| import { Client } from "discord.js" | |||
|
|
|||
| export default async function manageRole( | |||
There was a problem hiding this comment.
I would add this as an unexported helper to the renamed role-management script from #293 . If we do move to a directory for role management due to complexity, this can end up in a helpers file or similar.
Comment on lines
+5
to
+7
| guildId: string, | ||
| memberId: string, | ||
| roleId: string, |
There was a problem hiding this comment.
I'm not convinced we'll find ourselves wanting to do this without having handles to at least the guild and maybe member objects already... For example, the first use we're pondering, which would be in reaction to the guildMemberAdd event, would receive a GuildMember already—allowing us to bypass most of the steps here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This adds a
role-management.tsto Valkyrie which allows you to call the function on another script to add/remove roles based on the following criteria:Additional features
Whether we would like to include additional functionality into this PR such as invite management, role triggers, etc.