ASoC: SOF: ipc-topology: Add 8-bit S8 format support #5542
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch adds support for SNDRV_PCM_FORMAT_S8 into ipc4-topology.c. Signed-off-by: Seppo Ingalsuo <[email protected]>
singalsu
requested review from
bardliao,
dbaluta,
kv2019i,
lgirdwood,
plbossart,
ranj063 and
ujfalusi
as code owners
ujfalusi
reviewed
Sep 24, 2025
| break; | ||
| case SOF_IPC4_TYPE_SIGNED_INTEGER: | ||
| snd_fmt = SNDRV_PCM_FORMAT_S8; | ||
| break; |
Collaborator
There was a problem hiding this comment.
Fixes: c04c2e8 ("ASoC: SOF: ipc4-topology: Add support for 8-bit formats")
Author
There was a problem hiding this comment.
Is this kind of patch considered as fix? It's a new format supported. Though I missed this from an internal requirement that wasn't very specific.
I can add that line yes, if it's right for this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for SNDRV_PCM_FORMAT_S8 into ipc4-topology.c.