Skip to content

Conversation

@macchian
Copy link

This patch adds multi-lane support for the RT721 multi-function codec and the RT1320 amplifier when sharing SoundWire link 3.

@macchian
Copy link
Author

This is also no SDCA functions in BIOS. The Disco in SoundWire SW version is 1.0 version.

This patch adds multi-lane support for the RT721 multi-function
codec and the RT1320 amplifier when sharing SoundWire link 3.

Signed-off-by: Mac Chiang <[email protected]>
@macchian macchian marked this pull request as ready for review November 3, 2025 11:53
hubot pushed a commit to aosp-mirror/kernel_common that referenced this pull request Nov 5, 2025
This patch adds multi-lane support for the RT721 multi-function
codec and the RT1320 amplifier when sharing SoundWire link 3.

Bug: 443905714
Bug: 435094908
Test: run #cat /proc/asound/cards to check sound card is registered.
Upstream-Task: 455997202
Link: thesofproject/linux#5577

Signed-off-by: Mac Chiang <[email protected]>
Change-Id: I03a1bb4077523972f02407953a90cf586f5094c4
@macchian
Copy link
Author

@lgirdwood , This might need your review. Thanks.

.drv_name = "sof_sdw",
.sof_tplg_filename = "sof-ptl-rt721-l3-rt1320-l3.tplg",
.get_function_tplg_files = sof_sdw_get_tplg_files,
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use #5596 instead of adding matches for PTL?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. I would test it. Before that I assume this requires SDCA Disco table support, right? Currently, Disco SDCA functions is not yet supported in customer projects. Is it still able to load the best_effort link ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. I would test it. Before that I assume this requires SDCA Disco table support, right? Currently, Disco SDCA functions is not yet supported in customer projects. Is it still able to load the best_effort link ?

s/customer projects/chrome projects. I believe laptop projects all have SDCA Disco table support in the BIOS since it is required by Windows, too.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To correct my wording. Yes, I am mentioning the chrome and android projects.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@macchian, still we prefer to not add match entries if possible, so can you try the #5596 without this PR and see if you have audio probed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree the Disco table is preferred to match table. However, based on #5596, it requires the coreboot support the SDCA Disco table at first.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, this is for PTL, not NVL, right? Do we have the topology already built? We must have the topology built before we can add a new match entry (plus the -2ch and -4ch variants).

@bardliao, @kv2019i, should we allow more monolithic topologies to be added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants