-
Notifications
You must be signed in to change notification settings - Fork 140
ASoC: Intel: common: add rt721_l3_rt1320_l3 support #5577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: topic/sof-dev
Are you sure you want to change the base?
Conversation
|
This is also no SDCA functions in BIOS. The Disco in SoundWire SW version is 1.0 version. |
This patch adds multi-lane support for the RT721 multi-function codec and the RT1320 amplifier when sharing SoundWire link 3. Signed-off-by: Mac Chiang <[email protected]>
84c42a8 to
2fe9431
Compare
This patch adds multi-lane support for the RT721 multi-function codec and the RT1320 amplifier when sharing SoundWire link 3. Bug: 443905714 Bug: 435094908 Test: run #cat /proc/asound/cards to check sound card is registered. Upstream-Task: 455997202 Link: thesofproject/linux#5577 Signed-off-by: Mac Chiang <[email protected]> Change-Id: I03a1bb4077523972f02407953a90cf586f5094c4
|
@lgirdwood , This might need your review. Thanks. |
| .drv_name = "sof_sdw", | ||
| .sof_tplg_filename = "sof-ptl-rt721-l3-rt1320-l3.tplg", | ||
| .get_function_tplg_files = sof_sdw_get_tplg_files, | ||
| }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use #5596 instead of adding matches for PTL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing. I would test it. Before that I assume this requires SDCA Disco table support, right? Currently, Disco SDCA functions is not yet supported in customer projects. Is it still able to load the best_effort link ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing. I would test it. Before that I assume this requires SDCA Disco table support, right? Currently, Disco SDCA functions is not yet supported in customer projects. Is it still able to load the best_effort link ?
s/customer projects/chrome projects. I believe laptop projects all have SDCA Disco table support in the BIOS since it is required by Windows, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To correct my wording. Yes, I am mentioning the chrome and android projects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree the Disco table is preferred to match table. However, based on #5596, it requires the coreboot support the SDCA Disco table at first.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch adds multi-lane support for the RT721 multi-function codec and the RT1320 amplifier when sharing SoundWire link 3.