sof_sdw_utils: Call rtd_init() on the correct codec_info_list[] entry #5615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
include/sdw_type.h provides the function is_sdw_slave() which requires sdw_slave_type. But sdw_slave_type it was not exported. Change-Id: I629f9c120d443308b03bbc90cbe71d259bd15bd6 Signed-off-by: Richard Fitzgerald <[email protected]>
asoc_sdw_rtd_init() needs to call the rtd_init() callbacks for each codec in a dailink. It was finding the codecs by looking for the matching DAI name in codec_info_list[] but this is not reliable because the DAI name isn't guaranteed to be unique. Parts using the same codec driver (so the same DAI names) might require different machine driver setup. Instead, get the struct sdw_slave for the dai->component and from that the soundWire part ID can be extracted. This can be used to match against the .part_id value in codec_info_list[]. Change-Id: Ic89712176e1c7289ec00e8c6ef83a6677874d953 Signed-off-by: Richard Fitzgerald <[email protected]>
Remove the asoc_sdw_find_codec_info_dai() function because it isn't reliable and is now unused. It was finding the entry in codec_info_list[] by looking for the matching DAI name. But this is not reliable because the DAI name isn't guaranteed to be unique. Parts using the same codec driver (so the same DAI names) might require different machine driver setup. Change-Id: I178b5e136436b9259242fd5a79e39c011211ca7d Signed-off-by: Richard Fitzgerald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.