Sound support for the Samsung Galaxy Book 4 #5616

BreadJS · 2025-12-06T00:12:24Z

Why this PR?

I bought my Samsung Galaxy Book 4 Pro almost a year ago and wanted to run Linux. But was unsatisfied with the fact that there were no sound drivers available. After opening up the laptop I discovered there was a MAX98390 chip in the system connected through the ACPI. But after a long time there was no success on getting this working, until now!

What does this PR do?

The file sound/soc/codecs/max98390.c was missing a match for the MAX98390. It only was saying MX98390 and not MAX98390. Not only that, but lots of registers were initialized and also includes the DSM coefficients for basic but good enough sound.

More information

Sorry if this is not the right way to include this in the linux kernel. This is my first time making a PR to such big repo. Let me know if I need to change things and will try my best. Others are able to do this for me too if really needed. I will most likely add a second PR later, to add DSM coefficients from windows. This is being extracted by someone I'm working with.

sofci · 2025-12-06T00:13:02Z

Can one of the admins verify this patch?

reply test this please to run this test once

stephanlensky · 2025-12-07T02:27:38Z

This fixes #5002, #5568, and #5606.

stephanlensky · 2025-12-07T02:29:03Z

I've tested this on my own machine (Galaxy Book4 Pro 360 NP960QGK) under Arch Linux and can confirm sound works as expected. The quality is not exactly the same but pretty comparable to Windows.

Nice work @BreadJS!

stephanlensky · 2025-12-07T02:35:22Z

This also fixes the following kernel bugzillas:

BreadJS · 2025-12-07T02:35:32Z

Thank you @stephanlensky

This also fixes issue #5483 and #5026

melvyn2 · 2025-12-07T03:27:04Z

Should an entry also be added to alc269_fixup_models?

BreadJS · 2025-12-07T13:39:16Z

@melvyn2 Good call. I added it. (alc298-samsung-max98390-4-amps) I hope we get the PCI Device ID for the following models for auto detection:

- [x] Samsung Galaxy Book 4 Pro (14-inch)
- [x] Samsung Galaxy Book 4 Pro (16-inch)
- [x] Samsung Galaxy Book 4 Pro 360
- [x] Samsung Galaxy Book 4 Ultra
- [ ] Samsung Galaxy Book 4 360
- [ ] Samsung Galaxy Book 4 (base model)
- [ ] Samsung Galaxy Book 4 Edge
- [x] Samsung Galaxy Book 5 Pro 360
- [ ] Samsung Galaxy Book 5 Pro (16-inch)
- [ ] Samsung Galaxy Book 5 Pro (15.6-inch)
- [ ] Samsung Galaxy Book 5 360
- [ ] Samsung Galaxy Book 5 (base model)
- [ ] Samsung Galaxy Book 5 (ARC GPU)

I have no idea if there is a difference between the 14 and 16 inch variants and such.
If you have one of these models, please give me the PCI Device ID by doing the following:

$ lspci -vvv | grep "Multimedia audio"
00:1f.3 Multimedia audio controller: Intel Corporation Meteor Lake-P HD Audio Controller (rev 20)
$ cat /sys/bus/pci/devices/0000:00:1f.3/subsystem_device
0xc892 <- this is what we need

melvyn2 · 2025-12-07T22:20:36Z

0xc1da for the Galaxy Book5 Pro 360, which this also works for.

melvyn2 · 2025-12-07T22:24:16Z

sound/hda/codecs/realtek/alc269.c

 	{.id = ALC298_FIXUP_SAMSUNG_AMP, .name = "alc298-samsung-amp"},
 	{.id = ALC298_FIXUP_SAMSUNG_AMP_V2_2_AMPS, .name = "alc298-samsung-amp-v2-2-amps"},
 	{.id = ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS, .name = "alc298-samsung-amp-v2-4-amps"},
+	{.id = ALC298_FIXUP_SAMSUNG_AMP_V2_4_AMPS, .name = "alc298-samsung-amp-v2-4-amps"},


Seems like this line was accidentally duplicated.

Fixed! Thank you for noticing!

BreadJS · 2025-12-07T23:31:13Z

0xc1da for the Galaxy Book5 Pro 360, which this also works for.

Wait really? This worked on the Samsung Galaxy Book 5 Pro 360?
I thought they used different amp chips. Oh well, good to know it works for the Book 5 😄

hopugop · 2025-12-08T02:02:44Z

I hope we get the PCI Device ID for the following models for auto detection:

Samsung Galaxy Book4 Ultra

Here's my dev info for Book4 Ultra:

$ lspci -vvv | grep "Multimedia audio"
00:1f.3 Multimedia audio controller: Intel Corporation Meteor Lake-P HD Audio Controller (rev 20)
$ cat /sys/bus/pci/devices/0000:00:1f.3/subsystem_device
0xc1d8
$

The current patch does not work on this model. (Maybe it wasn't even supposed to?)
I can help testing patches on this model if needed.

Gaspardctrl · 2025-12-08T11:01:23Z

I hope we get the PCI Device ID for the following models for auto detection:
- [ ] Samsung Galaxy Book4 Pro (16-inch)
- [ ] Samsung Galaxy Book4 (base model)
- [ ] Samsung Galaxy Book4 Edge
I have no idea if there is a difference between the 14 and 16 inch variants and such.

Here's my dev info for Galaxy Book4 Pro (16-inch) NP960XGK:

$ lspci -vvv | grep "Multimedia audio"
00:1f.3 Multimedia audio controller: Intel Corporation Meteor Lake-P HD Audio Controller (rev 20)
$ cat /sys/bus/pci/devices/0000:00:1f.3/subsystem_device
0xc890

BreadJS · 2025-12-08T14:07:40Z

I hope we get the PCI Device ID for the following models for auto detection:

Samsung Galaxy Book4 Ultra

Here's my dev info for Book4 Ultra:
$ lspci -vvv | grep "Multimedia audio"
00:1f.3 Multimedia audio controller: Intel Corporation Meteor Lake-P HD Audio Controller (rev 20)
$ cat /sys/bus/pci/devices/0000:00:1f.3/subsystem_device
0xc1d8
$ 
The current patch does not work on this model. (Maybe it wasn't even supposed to?) I can help testing patches on this model if needed.

It most likely did not work because the PCI Quirk was not added. It is now, Please try again and see if it works now. If it still does not work, please connect me at the official discord server: https://discord.gg/wR8mM9pvVa

kv2019i · 2025-12-08T15:27:04Z

@BreadJS Excellent news that this was solved! As none of the changes fall under SOF (linux/sound/soc/sof/), patches submitted here cannot me merged here. Can you submit this series to Linux upstream ? [email protected] and see https://kernel.org/doc/html/latest/process/submitting-patches.html Please do refer to existing bugs like https://bugzilla.kernel.org/show_bug.cgi?id=220808 , this will likely help a lot of affected users.

BreadJS · 2025-12-08T15:33:45Z

@kv2019i Aah okay! I thought that this patch was for SOF. Thank you for letting me know! I will be trying to do that! Thank you very much!

chriswa81 · 2025-12-08T15:50:15Z

Hi,
I can confirm that this patch is also relevant for the Samsung Galaxy Book5 Pro 360 (Lunar Lake).
My subsystem device ID is 0xc1da.

I’m currently running Linux Mint (Ubuntu-based) and would be very happy to test this once a patched kernel is available for Ubuntu/Mint users.

Thanks a lot for the amazing work on this!

omarsoufiane · 2025-12-08T16:11:01Z

@BreadJS can you update your Stripe account in bountyhub for the bounty reward? I tried to reach you through email, and I'm not sure if you got my email.

BreadJS · 2025-12-08T16:32:40Z

@BreadJS can you update your Stripe account in bountyhub for the bounty reward? I tried to reach you through email, and I'm not sure if you got my email.

I do not have a stripe account, is this required? Can I not use paypal?

omarsoufiane · 2025-12-08T16:37:42Z

@BreadJS can you update your Stripe account in bountyhub for the bounty reward? I tried to reach you through email, and I'm not sure if you got my email.

I do not have a stripe account, is this required? Can I not use paypal?

it's an Express connected account that can be created from bountyhub's dashboard, not a Stripe account for businesses. Fees are lower than PayPal.

BreadJS · 2025-12-08T16:46:34Z

@BreadJS can you update your Stripe account in bountyhub for the bounty reward? I tried to reach you through email, and I'm not sure if you got my email.

I do not have a stripe account, is this required? Can I not use paypal?

it's an Express connected account that can be created from bountyhub's dashboard, not a Stripe account for businesses. Fees are lower than PayPal.

It should be resolved now###

hopugop · 2025-12-08T17:43:41Z

Confirmed working after c4a897b on Book4 Ultra 0xc1d8

arter97 · 2025-12-10T10:15:03Z

Dope, thanks a lot for this!

arter97

Just performed some minor code reviews. I'm no authority in kernel maintaining in any subsystems but hope this helps.

Let me know if you need any help in upstreaming this.
While having SOF review this is nice, we ultimately need to do the email method for upstreaming.

arter97 · 2025-12-10T11:18:39Z

sound/hda/codecs/side-codecs/max98390_hda.c

+
+	switch (action) {
+	case HDA_GEN_PCM_ACT_OPEN:
+


Remove whitespace line.

arter97 · 2025-12-10T11:19:51Z

sound/hda/codecs/side-codecs/max98390_hda.c

+	strscpy(comp->name, dev_name(dev), sizeof(comp->name));
+	comp->playback_hook = max98390_hda_playback_hook;
+
+	dev_info(dev, "MAX98390 HDA component bound (index %d)\n", priv->index);


Replace pretty much all dev_info()s to dev_dbg(). These are too verbose for upstream.

arter97 · 2025-12-10T11:21:18Z

sound/hda/codecs/side-codecs/max98390_hda.c

+		return ret;
+
+	ret = component_add(dev, &max98390_hda_comp_ops);
+	if (ret) {


Remove curly-brackets for single-lined branch.

arter97 · 2025-12-10T11:23:17Z

sound/hda/codecs/side-codecs/max98390_hda_filters.c

@@ -0,0 +1,334 @@
+// High-pass filter configuration for MAX98390 HDA driver


Missing SPDK identifier.

arter97 · 2025-12-10T11:23:40Z

sound/hda/codecs/side-codecs/max98390_hda.c

@@ -0,0 +1,214 @@
+// SPDX-License-Identifier: GPL-2.0
+//


Nit: Use /* */?

arter97 · 2025-12-10T11:24:37Z

sound/hda/codecs/side-codecs/max98390_hda_filters.c

+// Configure DSM with appropriate firmware based on speaker type
+// cutoff_freq: cutoff frequency in Hz (unused - filter built into tweeter firmware)
+// is_tweeter: true for tweeters (0x3C, 0x3D), false for woofers (0x38, 0x39)
+void max98390_configure_high_pass_filter(struct max98390_hda_priv *priv, int cutoff_freq, bool is_tweeter)


This is not used outside. Mark it static and remove it from the header file.

arter97 · 2025-12-10T11:25:34Z

sound/hda/codecs/side-codecs/max98390_hda_filters.c

+		}
+	}
+
+	// For WOOFERS: Apply EasyEffects EQ using BQ1


Huh? Why is EasyEffects mentioned here? Are we applying kernel-level equalizer configurations? Or is this something that stock Windows drivers perform?

arter97 · 2025-12-10T11:27:13Z

sound/hda/codecs/side-codecs/max98390_hda_filters.h

+void max98390_configure_filters(struct max98390_hda_priv *priv);
+void max98390_configure_high_pass_filter(struct max98390_hda_priv *priv, int cutoff_freq, bool is_tweeter);
+
+#endif /* __MAX98390_HDA_FILTERS_H */


All files must have an empty line at the end.

Sound support for the Samsung Galaxy Book 4

57088c5

BreadJS requested review from bardliao, dbaluta, kv2019i, lgirdwood, plbossart, ranj063 and ujfalusi as code owners December 6, 2025 00:12

stephanlensky mentioned this pull request Dec 7, 2025

Samsung Galaxy Book4 Pro 14" (NP940XGK) - speakers do not work #5002

Open

BreadJS added 2 commits December 7, 2025 14:28

Rename model number of Book4 360 and Book4 Pro

4898a18

Added fixup model

4a4b843

Typo: Book 4 360 was a Book 4 Pro 360

0a4ffae

melvyn2 reviewed Dec 7, 2025

View reviewed changes

Added Galaxy Book 5 and removed duplicated line

774c875

Added support for Book4 Pro 16-inch and Book4 Ultra

c4a897b

arter97 reviewed Dec 10, 2025

View reviewed changes

		@@ -0,0 +1,334 @@
		// High-pass filter configuration for MAX98390 HDA driver

Sound support for the Samsung Galaxy Book 4 #5616

Are you sure you want to change the base?

Sound support for the Samsung Galaxy Book 4 #5616

Conversation

BreadJS commented Dec 6, 2025

Why this PR?

What does this PR do?

More information

Uh oh!

sofci commented Dec 6, 2025

Uh oh!

stephanlensky commented Dec 7, 2025

Uh oh!

stephanlensky commented Dec 7, 2025

Uh oh!

stephanlensky commented Dec 7, 2025

Uh oh!

BreadJS commented Dec 7, 2025

Uh oh!

melvyn2 commented Dec 7, 2025

Uh oh!

BreadJS commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvyn2 commented Dec 7, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BreadJS Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BreadJS commented Dec 7, 2025

Uh oh!

hopugop commented Dec 8, 2025

Uh oh!

Gaspardctrl commented Dec 8, 2025

Uh oh!

BreadJS commented Dec 8, 2025

Uh oh!

kv2019i commented Dec 8, 2025

Uh oh!

BreadJS commented Dec 8, 2025

Uh oh!

chriswa81 commented Dec 8, 2025

Uh oh!

omarsoufiane commented Dec 8, 2025

Uh oh!

BreadJS commented Dec 8, 2025

Uh oh!

omarsoufiane commented Dec 8, 2025

Uh oh!

BreadJS commented Dec 8, 2025

Uh oh!

hopugop commented Dec 8, 2025

Uh oh!

arter97 commented Dec 10, 2025

Uh oh!

arter97 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

BreadJS commented Dec 7, 2025 •

edited

Loading

BreadJS Dec 7, 2025 •

edited

Loading