-
Notifications
You must be signed in to change notification settings - Fork 347
topology2: add cpc value for gain #7242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The missing cpc in gain component results in wrong calculation for clock selection, and causes capture issues. Link: thesofproject#7228 Link: thesofproject#7230 Signed-off-by: Chao Song <[email protected]>
abonislawski
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @aiChaoSONG can you also update other modules to match the manifest data?
|
@RanderWang @abonislawski CPC for all modules in manifest are zero, but we also have CPS there, is it ok for you to calculate CPC from the maximum CPS for the module, to make CPC work for all supported formats. I see several formula, could you please clarify which one is correct? The value 10183 for gain you write here #7228 (comment) seems not aligned with any of the above formula. how is it calculated? |
|
@aiChaoSONG please use mtl-004 manifest as a reference: @kfrydryx could you please clarify cps/cpc calculations? |
|
@abonislawski @aiChaoSONG CPS means cycles per second and CPC - cycles per chunk. And since we have 1ms scheduling period, |
|
FYI @mwasko @lgirdwood -- the relation to topology (and how to calculate) needs to be covered in sof-docs (related to thesofproject/sof-docs#451 ) |
|
https://sof-ci.01.org/sofpr/PR7242/build4478/devicetest/index.html hit a case of #7184 . Not related to this PR. Proceeding with merge. |
The missing cpc in gain component results in wrong calculation for clock selection, and causes capture issues.
Link: #7228
Link: #7230