-
Notifications
You must be signed in to change notification settings - Fork 347
Pipeline2.0: step3, make all components using API instead of direct access to bsink_list and bsource_list #9478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kv2019i
merged 5 commits into
thesofproject:main
from
marcinszkudlinski:pipeline2_0_003
Sep 19, 2024
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1b5d1fe
buf: add API functions for accessing comp_buffer lists
marcinszkudlinski f5db20a
buf: make all the modules use comp_dev_get_first_data_consumer
marcinszkudlinski 5c35b40
buf: use API for sink iteration in components
marcinszkudlinski f42fb8b
buf: make all the modules use comp_dev_get_first_data_producer
marcinszkudlinski e48aab8
buf: use API for iteration bsource_list in components
marcinszkudlinski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -634,6 +634,64 @@ struct comp_dev { | |
| #endif | ||
| }; | ||
|
|
||
| /** | ||
| * Get a pointer to a first comp_buffer object providing data to the component | ||
| * The procedure will return NULL if there's no data provider | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wow "procedure" takes me back to Pascal times :-) |
||
| */ | ||
| static inline struct comp_buffer *comp_dev_get_first_data_producer(struct comp_dev *component) | ||
| { | ||
| return list_is_empty(&component->bsource_list) ? NULL : | ||
| list_first_item(&component->bsource_list, struct comp_buffer, sink_list); | ||
| } | ||
|
|
||
| /** | ||
| * Get a pointer to a next comp_buffer object providing data to the component | ||
marcinszkudlinski marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| * The procedure will return NULL if there're no more data providers | ||
| */ | ||
| static inline struct comp_buffer *comp_dev_get_next_data_producer(struct comp_dev *component, | ||
| struct comp_buffer *producer) | ||
| { | ||
| return producer->sink_list.next == &component->bsource_list ? NULL : | ||
| list_item(producer->sink_list.next, struct comp_buffer, sink_list); | ||
| } | ||
|
|
||
| /** | ||
| * Get a pointer to a first comp_buffer object receiving data from the component | ||
| * The procedure will return NULL if there's no data consumers | ||
| */ | ||
| static inline struct comp_buffer *comp_dev_get_first_data_consumer(struct comp_dev *component) | ||
| { | ||
| return list_is_empty(&component->bsink_list) ? NULL : | ||
| list_first_item(&component->bsink_list, struct comp_buffer, source_list); | ||
| } | ||
|
|
||
| /** | ||
| * Get a pointer to a next comp_buffer object receiving data from the component | ||
| * The procedure will return NULL if there're no more data consumers | ||
| */ | ||
| static inline struct comp_buffer *comp_dev_get_next_data_consumer(struct comp_dev *component, | ||
| struct comp_buffer *consumer) | ||
| { | ||
| return consumer->source_list.next == &component->bsink_list ? NULL : | ||
| list_item(consumer->source_list.next, struct comp_buffer, source_list); | ||
| } | ||
|
|
||
| /* | ||
| * a macro for easy iteration through component's list of producers | ||
| */ | ||
| #define comp_dev_for_each_producer(_dev, _producer) \ | ||
| for (_producer = comp_dev_get_first_data_producer(_dev); \ | ||
| _producer != NULL; \ | ||
| _producer = comp_dev_get_next_data_producer(_dev, _producer)) | ||
|
|
||
| /* | ||
| * a macro for easy iteration through component's list of consumers | ||
| */ | ||
| #define comp_dev_for_each_consumer(_dev, _consumer) \ | ||
| for (_consumer = comp_dev_get_first_data_consumer(_dev); \ | ||
| _consumer != NULL; \ | ||
| _consumer = comp_dev_get_next_data_consumer(_dev, _consumer)) | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: you could code golf these two macros into one for loop expansion |
||
|
|
||
| /** @}*/ | ||
|
|
||
| /* Common helper function used internally by the component implementations | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.