Skip to content

Conversation

@vanlooverenkoen
Copy link

Fixed #104

@vanlooverenkoen
Copy link
Author

@lukef any idea how we can get this merged?

@vanlooverenkoen
Copy link
Author

vanlooverenkoen commented Feb 23, 2022

We are using this branch in production for over 7 months. Our app has 7 million installs. And we never had one complaint about a qr code that could not be scanned correctly. So I do think this can be merged and released

@lukef
Copy link
Collaborator

lukef commented Mar 3, 2022

Yep. This will be fixed in 5.0. I rewrote part of that code (for various reasons). Keeping this open as a reminder but you can check the (sometimes broken) work in progress on the wip-50 branch.

Heads up, 5.0 will break compatibility. Feedback welcome.

@lukef
Copy link
Collaborator

lukef commented Mar 3, 2022

Specific fixes are:

  1. no longer round the module size (your original change).
  2. disable antialiasing for square module styles when they're being drawn in a gapless context. This avoids the "ghost gap" that code was seeking to eliminate.

@vanlooverenkoen
Copy link
Author

Alright thanks already. We will migrate when this pull request in closed (meaning it is released)

@vanlooverenkoen
Copy link
Author

@lukef any progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Padding does not work as expected

2 participants