Add establish connection to the alias hijacking.#427
Open
abMatGit wants to merge 1 commit into
Open
Conversation
Owner
|
hey @abMatGit - could you check why the test suite is failing? Thanks |
|
It seems like the tests are failing because he replaced |
|
It doesn't - I think this will require a more significant patch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #426
Kudos to @camertron! \o/
Proposed solution:
Alias the
establish_connectionmethod to explicitly and return anestablish_connection_without_octopusconnection.This will cause
establish_connection configuration_without_databaseto return aMySQL2::Adapterclass instead of aOctopus::Proxyclass, from which we can successfully callconnection.create_databaseand bypassOctopus::Proxy#method_missing