Skip to content

Fixed the CAP_NET_RAW capabilities were not inherited. - #928

Open
MusclePr wants to merge 5 commits into
thijsvanloef:mainfrom
MusclePr:911/fix_inherit_caps
Open

Fixed the CAP_NET_RAW capabilities were not inherited.#928
MusclePr wants to merge 5 commits into
thijsvanloef:mainfrom
MusclePr:911/fix_inherit_caps

Conversation

@MusclePr

@MusclePr MusclePr commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Context

  1. Fixed for Auto pause cannot unpause #911
    Containers are governed by the host OS's capabilities.
    It was necessary to properly specify capabilities when switching from root to a user.

  2. Fixed an issue where the access token was not immediately displayed due to Python log buffering when COMMUNITY=true and AUTO_PAUSE_DEBUG=true were used.

  3. Ultimately, this became an alternative implementation for Switched to gosu #908.

Choices

  • su -c steam <cmd>
  • setpriv --reuid=steam --regid=steam --init-groups --inh-caps="$caps" --ambient-caps="$caps" <cmd>

Test instructions

  1. Add AUTO_PAUSE_DEBUG=true env var to examples/autopause/compose.yaml .
  2. Run on an actual Debian Trixie host,
    docker compose --project-directory examples/autopause up
  3. Verify token message in log.
  4. Verify that no permission error occurs during PAUSE.

Checklist before requesting a review

  • I have performed a self-review/test of my code
  • No documentation updates are required for this fix.
  • I've not introduced breaking changes.
  • My changes do not violate linting rules.

AI Usage Disclosure

Please read the AI Usage Guidelines for Contributors before submitting this PR.
If you used an AI tool to assist in writing or refactoring code for this PR, please disclose it below.

  • I used GitHub Copilot to assist in modifications for this PR.
    I have manually reviewed the generated code and tested the container build locally.

@MusclePr
MusclePr marked this pull request as ready for review August 9, 2026 17:01
@thijsvanloef
thijsvanloef requested a balanced review from Copilot August 20, 2026 19:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes capability inheritance for auto-pause monitoring and improves community proxy logging.

Changes:

  • Replaces su with a capability-aware user launcher.
  • Improves FIFO cleanup and unbuffered mitmproxy output.
  • Updates proxy exclusions and auto-pause example settings.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
scripts/helper_functions.sh Adds capability-aware process launching.
scripts/init.sh Cleans FIFO and launches server as steam.
scripts/start.sh Uses the shared user launcher.
scripts/autopause/community/init.sh Updates proxy exclusions and buffering.
examples/autopause/compose.yaml Enables auto-pause logging.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/autopause/community/init.sh Outdated
Comment thread scripts/helper_functions.sh Outdated
@MusclePr
MusclePr force-pushed the 911/fix_inherit_caps branch from eab5309 to c457c83 Compare August 21, 2026 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants