-
Notifications
You must be signed in to change notification settings - Fork 579
Dashboard: Fix WalletAddress ens image size #7935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Fix WalletAddress ens image size #7935
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
WalkthroughUI refinements: reduced badge/icon and avatar sizes, added a Blobbie fallback for missing avatar images, and removed an unused Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Warning Review ran into problems🔥 ProblemsErrors were encountered while retrieving linked issues. Errors (1)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
✨ Finishing Touches
🧪 Generate unit tests
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7935 +/- ##
=======================================
Coverage 56.55% 56.55%
=======================================
Files 904 904
Lines 58581 58581
Branches 4142 4142
=======================================
Hits 33128 33128
Misses 25347 25347
Partials 106 106
🚀 New features to boost your workflow:
|
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
apps/dashboard/src/@/components/blocks/wallet-address.tsx (2)
51-53
: Invalid-address badge size tweak looks good; set icon as decorative for a11yAdd aria-hidden to the X icon so screen readers don’t announce a redundant glyph.
<div className="flex size-5 items-center justify-center rounded-full border bg-background"> - <XIcon className="size-4 text-muted-foreground" /> + <XIcon aria-hidden="true" className="size-4 text-muted-foreground" /> </div>
65-66
: Zero-address icon: mark decorative and avoid SR noiseSame a11y nit: hide the icon from screen readers.
- <CircleSlashIcon - className={cn("size-5 text-muted-foreground/70", props.iconClassName)} - /> + <CircleSlashIcon + aria-hidden="true" + className={cn("size-5 text-muted-foreground/70", props.iconClassName)} + />
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/dashboard/src/@/components/blocks/wallet-address.tsx
(3 hunks)apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/RecentTransfers.tsx
(0 hunks)
💤 Files with no reviewable changes (1)
- apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/RecentTransfers.tsx
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}
: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from@/types
or localtypes.ts
barrels
Prefer type aliases over interface except for nominal shapes
Avoidany
andunknown
unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial
,Pick
, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose
Files:
apps/dashboard/src/@/components/blocks/wallet-address.tsx
**/*.{ts,tsx,js,jsx}
📄 CodeRabbit inference engine (CLAUDE.md)
Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)
Files:
apps/dashboard/src/@/components/blocks/wallet-address.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
apps/{dashboard,playground-web}/**/*.{ts,tsx}
: Import UI primitives from@/components/ui/*
(Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
UseNavLink
for internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Usecn()
from@/lib/utils
for conditional class logic
Use design system tokens (e.g.,bg-card
,border-border
,text-muted-foreground
)
Server Components (Node edge): Start files withimport "server-only";
Client Components (browser): Begin files with'use client';
Always callgetAuthToken()
to retrieve JWT from cookies on server side
UseAuthorization: Bearer
header – never embed tokens in URLs
Return typed results (e.g.,Project[]
,User[]
) – avoidany
Wrap client-side data fetching calls in React Query (@tanstack/react-query
)
Use descriptive, stablequeryKeys
for React Query cache hits
ConfigurestaleTime
/cacheTime
in React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never importposthog-js
in server components
Files:
apps/dashboard/src/@/components/blocks/wallet-address.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: Size
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/dashboard/src/@/components/blocks/wallet-address.tsx (2)
223-226
: Blobbie size matches containerUsing size={20} aligns with the outer size-5 (20px). Consistent and tidy.
208-218
: The script is running to show the prop definitions forImg
. I’ll review whetheralt
is supported and then update the comment accordingly.
Merge activity
|
<!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR primarily focuses on adjusting the size of certain UI components in the `RecentTransfers` and `WalletAddress` sections, ensuring a more consistent design across the dashboard. ### Detailed summary - In `RecentTransfers.tsx`, removed the `iconClassName` prop from a component. - In `wallet-address.tsx`, changed the size of a `div` from `size-6` to `size-5`. - Updated the `CircleSlashIcon` size from `size-6` to `size-5`. - Added a `fallback` prop to the `Img` component in `WalletAvatar`. - Changed the `size` of the `Blobbie` component in `WalletAvatar` from `24` to `20`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex --> <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - New Features - Added automatic address-based avatar fallback when a wallet/avatar image isn’t available. - Style - Reduced sizes for the invalid-address badge and zero-address indicator for better visual balance. - Adjusted fallback avatar size for improved consistency. - Standardized icon sizing in Recent Transfers by removing a custom icon size override. - Overall, wallet/address visuals are cleaner and more consistent across the dashboard. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
c008bcd
to
0853872
Compare
PR-Codex overview
This PR focuses on making adjustments to the styling and structure of the
RecentTransfers
andWalletAddress
components. It primarily involves changing size properties for better UI consistency.Detailed summary
RecentTransfers.tsx
, removed-iconClassName="size-4.5"
from transfer elements.wallet-address.tsx
, changed thesize
fromsize-6
tosize-5
for the address display.CircleSlashIcon
class size fromsize-6
tosize-5
.fallback
prop toWalletAvatar
with aBlobbie
component.Blobbie
size from24
to20
.Summary by CodeRabbit
New Features
Style