Skip to content

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Aug 27, 2025


PR-Codex overview

This PR focuses on making adjustments to the styling and structure of the RecentTransfers and WalletAddress components. It primarily involves changing size properties for better UI consistency.

Detailed summary

  • In RecentTransfers.tsx, removed -iconClassName="size-4.5" from transfer elements.
  • In wallet-address.tsx, changed the size from size-6 to size-5 for the address display.
  • Updated the CircleSlashIcon class size from size-6 to size-5.
  • Added a fallback prop to WalletAvatar with a Blobbie component.
  • Adjusted the Blobbie size from 24 to 20.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • New Features

    • Added automatic address-based avatar fallback (Blobbie) when a wallet/avatar image isn’t available.
  • Style

    • Reduced sizes for the invalid-address badge and zero-address indicator for better visual balance.
    • Adjusted fallback avatar size for improved consistency.
    • Standardized icon sizing in Recent Transfers by removing a custom icon size override.

Copy link

vercel bot commented Aug 27, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
thirdweb-www Ready Ready Preview Comment Aug 28, 2025 0:24am
4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
docs-v2 Skipped Skipped Aug 28, 2025 0:24am
nebula Skipped Skipped Aug 28, 2025 0:24am
thirdweb_playground Skipped Skipped Aug 28, 2025 0:24am
wallet-ui Skipped Skipped Aug 28, 2025 0:24am

@vercel vercel bot temporarily deployed to Preview – nebula August 27, 2025 23:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 27, 2025 23:11 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 27, 2025 23:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 27, 2025 23:11 Inactive
Copy link

changeset-bot bot commented Aug 27, 2025

⚠️ No Changeset found

Latest commit: 0853872

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Aug 27, 2025

Walkthrough

UI refinements: reduced badge/icon and avatar sizes, added a Blobbie fallback for missing avatar images, and removed an unused iconClassName prop in two RecentTransfers WalletAddress usages. No exported/public API signature changes.

Changes

Cohort / File(s) Summary
Wallet address UI adjustments
apps/dashboard/src/@/components/blocks/wallet-address.tsx
Shrink invalid-address badge and ZERO_ADDRESS icon from size-6 to size-5; add WalletAvatar Img fallback that renders an address-based Blobbie when resolvedAvatarSrc is absent; reduce Blobbie fallback size from 24 to 20; no exported API changes.
RecentTransfers prop cleanup
apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/RecentTransfers.tsx
Removed iconClassName="size-4.5" prop from two WalletAddress usages (From and To columns); rendering logic unchanged; no API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • TEAM-0000: Entity not found: Issue - Could not find referenced Issue.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between c008bcd and 0853872.

📒 Files selected for processing (2)
  • apps/dashboard/src/@/components/blocks/wallet-address.tsx (3 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/RecentTransfers.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/RecentTransfers.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/dashboard/src/@/components/blocks/wallet-address.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Size
  • GitHub Check: E2E Tests (pnpm, esbuild)
  • GitHub Check: E2E Tests (pnpm, vite)
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch 08-28-dashboard_fix_walletaddress_ens_image_size

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@MananTank MananTank marked this pull request as ready for review August 27, 2025 23:12
@MananTank MananTank requested review from a team as code owners August 27, 2025 23:12
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Aug 27, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Aug 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.55%. Comparing base (44e6e11) to head (0853872).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7935   +/-   ##
=======================================
  Coverage   56.55%   56.55%           
=======================================
  Files         904      904           
  Lines       58581    58581           
  Branches     4142     4142           
=======================================
  Hits        33128    33128           
  Misses      25347    25347           
  Partials      106      106           
Flag Coverage Δ
packages 56.55% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Aug 27, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 64.06 KB (0%) 1.3 s (0%) 107 ms (+154.58% 🔺) 1.4 s
thirdweb (cjs) 357.05 KB (0%) 7.2 s (0%) 350 ms (+16.02% 🔺) 7.5 s
thirdweb (minimal + tree-shaking) 5.73 KB (0%) 115 ms (0%) 27 ms (+984.63% 🔺) 142 ms
thirdweb/chains (tree-shaking) 526 B (0%) 11 ms (0%) 30 ms (+3908.08% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.15 KB (0%) 383 ms (0%) 32 ms (+319.15% 🔺) 415 ms

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (2)
apps/dashboard/src/@/components/blocks/wallet-address.tsx (2)

51-53: Invalid-address badge size tweak looks good; set icon as decorative for a11y

Add aria-hidden to the X icon so screen readers don’t announce a redundant glyph.

   <div className="flex size-5 items-center justify-center rounded-full border bg-background">
-    <XIcon className="size-4 text-muted-foreground" />
+    <XIcon aria-hidden="true" className="size-4 text-muted-foreground" />
   </div>

65-66: Zero-address icon: mark decorative and avoid SR noise

Same a11y nit: hide the icon from screen readers.

-        <CircleSlashIcon
-          className={cn("size-5 text-muted-foreground/70", props.iconClassName)}
-        />
+        <CircleSlashIcon
+          aria-hidden="true"
+          className={cn("size-5 text-muted-foreground/70", props.iconClassName)}
+        />
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f79672e and c008bcd.

📒 Files selected for processing (2)
  • apps/dashboard/src/@/components/blocks/wallet-address.tsx (3 hunks)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/RecentTransfers.tsx (0 hunks)
💤 Files with no reviewable changes (1)
  • apps/dashboard/src/app/(app)/(dashboard)/(chain)/[chain_id]/[contractAddress]/public-pages/erc20/_components/RecentTransfers.tsx
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

**/*.{ts,tsx}: Write idiomatic TypeScript with explicit function declarations and return types
Limit each file to one stateless, single-responsibility function for clarity
Re-use shared types from @/types or local types.ts barrels
Prefer type aliases over interface except for nominal shapes
Avoid any and unknown unless unavoidable; narrow generics when possible
Choose composition over inheritance; leverage utility types (Partial, Pick, etc.)
Comment only ambiguous logic; avoid restating TypeScript in prose

Files:

  • apps/dashboard/src/@/components/blocks/wallet-address.tsx
**/*.{ts,tsx,js,jsx}

📄 CodeRabbit inference engine (CLAUDE.md)

Load heavy dependencies inside async paths to keep initial bundle lean (lazy loading)

Files:

  • apps/dashboard/src/@/components/blocks/wallet-address.tsx
apps/{dashboard,playground-web}/**/*.{ts,tsx}

📄 CodeRabbit inference engine (CLAUDE.md)

apps/{dashboard,playground-web}/**/*.{ts,tsx}: Import UI primitives from @/components/ui/* (Button, Input, Select, Tabs, Card, Sidebar, Badge, Separator) in dashboard and playground apps
Use NavLink for internal navigation with automatic active states in dashboard and playground apps
Use Tailwind CSS only – no inline styles or CSS modules
Use cn() from @/lib/utils for conditional class logic
Use design system tokens (e.g., bg-card, border-border, text-muted-foreground)
Server Components (Node edge): Start files with import "server-only";
Client Components (browser): Begin files with 'use client';
Always call getAuthToken() to retrieve JWT from cookies on server side
Use Authorization: Bearer header – never embed tokens in URLs
Return typed results (e.g., Project[], User[]) – avoid any
Wrap client-side data fetching calls in React Query (@tanstack/react-query)
Use descriptive, stable queryKeys for React Query cache hits
Configure staleTime/cacheTime in React Query based on freshness (default ≥ 60s)
Keep tokens secret via internal API routes or server actions
Never import posthog-js in server components

Files:

  • apps/dashboard/src/@/components/blocks/wallet-address.tsx
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: Size
  • GitHub Check: Lint Packages
  • GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
apps/dashboard/src/@/components/blocks/wallet-address.tsx (2)

223-226: Blobbie size matches container

Using size={20} aligns with the outer size-5 (20px). Consistent and tidy.


208-218: The script is running to show the prop definitions for Img. I’ll review whether alt is supported and then update the comment accordingly.

Copy link
Contributor

graphite-app bot commented Aug 28, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR primarily focuses on adjusting the size of certain UI components in the `RecentTransfers` and `WalletAddress` sections, ensuring a more consistent design across the dashboard.

### Detailed summary
- In `RecentTransfers.tsx`, removed the `iconClassName` prop from a component.
- In `wallet-address.tsx`, changed the size of a `div` from `size-6` to `size-5`.
- Updated the `CircleSlashIcon` size from `size-6` to `size-5`.
- Added a `fallback` prop to the `Img` component in `WalletAvatar`.
- Changed the `size` of the `Blobbie` component in `WalletAvatar` from `24` to `20`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->

<!-- This is an auto-generated comment: release notes by coderabbit.ai -->

## Summary by CodeRabbit

- New Features
  - Added automatic address-based avatar fallback when a wallet/avatar image isn’t available.

- Style
  - Reduced sizes for the invalid-address badge and zero-address indicator for better visual balance.
  - Adjusted fallback avatar size for improved consistency.
  - Standardized icon sizing in Recent Transfers by removing a custom icon size override.
  - Overall, wallet/address visuals are cleaner and more consistent across the dashboard.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@graphite-app graphite-app bot force-pushed the 08-28-dashboard_fix_walletaddress_ens_image_size branch from c008bcd to 0853872 Compare August 28, 2025 12:14
@vercel vercel bot temporarily deployed to Preview – nebula August 28, 2025 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground August 28, 2025 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 August 28, 2025 12:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui August 28, 2025 12:14 Inactive
@graphite-app graphite-app bot merged commit 0853872 into main Aug 28, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 08-28-dashboard_fix_walletaddress_ens_image_size branch August 28, 2025 12:24
@vercel vercel bot temporarily deployed to Production – wallet-ui August 28, 2025 12:24 Inactive
@vercel vercel bot temporarily deployed to Production – nebula August 28, 2025 12:24 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants