Thom/add device groups to device list#86
Open
acosferreira wants to merge 8 commits intothom-at-redhat:mainfrom
Open
Thom/add device groups to device list#86acosferreira wants to merge 8 commits intothom-at-redhat:mainfrom
acosferreira wants to merge 8 commits intothom-at-redhat:mainfrom
Conversation
Bumps [github.com/aws/aws-sdk-go](https://github.com/aws/aws-sdk-go) from 1.43.37 to 1.43.38. - [Release notes](https://github.com/aws/aws-sdk-go/releases) - [Changelog](https://github.com/aws/aws-sdk-go/blob/main/CHANGELOG.md) - [Commits](aws/aws-sdk-go@v1.43.37...v1.43.38) --- updated-dependencies: - dependency-name: github.com/aws/aws-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…go_modules/github.com/aws/aws-sdk-go-1.43.38 Bump github.com/aws/aws-sdk-go from 1.43.37 to 1.43.38
…esetid Added image set id to /devicesview endpoint.
…fix-bug-commit-id Theedge 2003 fix bug commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The core problem that we are facing to get the device groups info on device list is because we are getting info from different places (DB and Inventory endpoint)
To be able to get the info we need to add the relationship (m2m) on devices, add the new field to the struct details and load the association when we get the DB info.
To consider this as done, is missing handle proper the errors and add test.
Hope this be helpful.
Fixes # (issue)
Type of change
What is it?
Checklist:
go fmt ./...to check that my code is properly formattedgo vet ./...to check that my code is free of common Go style mistakes