Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding openshift function and schedule workflow for sync-job #1260

Merged
merged 4 commits into from
Jun 6, 2022
Merged

adding openshift function and schedule workflow for sync-job #1260

merged 4 commits into from
Jun 6, 2022

Conversation

Gregory-Pereira
Copy link
Member

Related Issues and Dependencies

Related to: thoth-station/thoth-application#2513
Related to: thoth-station/management-api#887 (common changes)

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

Creates a schedule_sync_job function and a function to submit a workflow for the sync job.

/cc @fridex
/cc @harshad16

@sesheta sesheta requested review from fridex and harshad16 May 3, 2022 00:47
@sesheta sesheta added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 3, 2022
@Gregory-Pereira Gregory-Pereira force-pushed the add-schedule-sync-job-workflow branch from 7a3f4e6 to 6400605 Compare May 3, 2022 00:53
fridex
fridex reviewed May 3, 2022
View reviewed changes
Copy link
Contributor

@fridex fridex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment regarding workload placement. Thanks, Gregory! 💯 👍🏻

thoth/common/openshift.py Outdated Show resolved Hide resolved
harshad16
harshad16 requested changes May 3, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Thanks for the work.

thoth/common/workflows.py Show resolved Hide resolved
This was referenced May 9, 2022
Closed
Merged
@goern
Copy link
Member

goern commented May 16, 2022

is this good to approve?

fridex
fridex reviewed May 16, 2022
View reviewed changes
thoth/common/workflows.py Outdated Show resolved Hide resolved
thoth/common/workflows.py Outdated Show resolved Hide resolved
thoth/common/workflows.py Outdated Show resolved Hide resolved
harshad16 and others added 3 commits June 6, 2022 09:00
@harshad16 @fridex
Update thoth/common/workflows.py
9cbdc53 
Co-authored-by: Fridolín Pokorný <[email protected]>
@harshad16 @fridex
Update thoth/common/workflows.py
ea86ddf 
Co-authored-by: Fridolín Pokorný <[email protected]>
@harshad16 @fridex
Update thoth/common/workflows.py
5a05691 
Co-authored-by: Fridolín Pokorný <[email protected]>
harshad16
harshad16 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks 💯

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2022
@harshad16 harshad16 merged commit 2a5d90b into thoth-station:master Jun 6, 2022
@sesheta
Copy link
Member

sesheta commented Jun 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
To complete the pull request process, please assign fridex after the PR has been reviewed.
You can assign the PR to them by writing /assign @fridex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

2 similar comments
@sesheta
Copy link
Member

sesheta commented Jun 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
To complete the pull request process, please assign fridex after the PR has been reviewed.
You can assign the PR to them by writing /assign @fridex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sesheta
Copy link
Member

sesheta commented Jun 6, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
To complete the pull request process, please assign fridex after the PR has been reviewed.
You can assign the PR to them by writing /assign @fridex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex fridex left review comments

@harshad16 harshad16 harshad16 approved these changes

Assignees

@harshad16 harshad16

Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gregory-Pereira @goern @sesheta @fridex @harshad16