Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable sync job to be called from the management api #884

Merged
merged 1 commit into from
Jun 10, 2022
Merged

Enable sync job to be called from the management api #884

merged 1 commit into from
Jun 10, 2022

Conversation

Gregory-Pereira
Copy link
Member

@Gregory-Pereira Gregory-Pereira commented Apr 22, 2022 •
edited by harshad16
Loading

Related Issues and Dependencies

Partially addresses: thoth-station/thoth-application#2513 (task 3 / 4)
Related-to: #887

This introduces a breaking change

  • Yes
  • No

This Pull Request implements

New post endpoints for /graph/sync-job/{component-name}, that will trigger the sync job for those documents.
Component names:

  1. adviser
  2. solver
  3. revsolver
  4. package-extract
  5. provenance-checker
  6. security-indicators

/cc @harshad16 @fridex

@sesheta sesheta requested a review from harshad16 April 22, 2022 23:06
@sesheta sesheta added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 22, 2022
@Gregory-Pereira Gregory-Pereira force-pushed the enable-sync-job-from-management-api branch from aca2c62 to 49d6b66 Compare April 22, 2022 23:29
fridex
fridex reviewed Apr 25, 2022
View reviewed changes
openapi/openapi.yaml Outdated Show resolved Hide resolved
thoth/management_api/api_v1.py Outdated Show resolved Hide resolved
@harshad16 harshad16 mentioned this pull request May 2, 2022
Closed
3 tasks
@Gregory-Pereira Gregory-Pereira force-pushed the enable-sync-job-from-management-api branch 2 times, most recently from f439e75 to 0a7d0cf Compare May 9, 2022 15:56
@sesheta sesheta added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 9, 2022
@Gregory-Pereira Gregory-Pereira force-pushed the enable-sync-job-from-management-api branch 2 times, most recently from d958486 to ba38697 Compare May 9, 2022 15:58
@Gregory-Pereira Gregory-Pereira changed the title enable 6 document types of sync-job to be called from management api Enable sync job to be called from the management api May 9, 2022
harshad16
harshad16 requested changes May 9, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort 🎉

Is this been tested ?
does the change of the open API version cause any issue with the existing schema ?

thoth/management_api/sync_job_types.py Outdated Show resolved Hide resolved
openapi/openapi.yaml Show resolved Hide resolved
@Gregory-Pereira Gregory-Pereira force-pushed the enable-sync-job-from-management-api branch 4 times, most recently from bc29fe5 to 69f007d Compare May 11, 2022 16:55
harshad16
harshad16 requested changes Jun 6, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the changes
some more suggestions.

openapi/openapi.yaml Outdated Show resolved Hide resolved
thoth/management_api/api_v1.py Outdated Show resolved Hide resolved
thoth/management_api/api_v1.py Outdated Show resolved Hide resolved
openapi/openapi.yaml Outdated Show resolved Hide resolved
@Gregory-Pereira Gregory-Pereira force-pushed the enable-sync-job-from-management-api branch from f89c70f to 4cf8275 Compare June 7, 2022 18:13
harshad16
harshad16 requested changes Jun 7, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some more changes required

thoth/management_api/api_v1.py Outdated Show resolved Hide resolved
@Gregory-Pereira Gregory-Pereira force-pushed the enable-sync-job-from-management-api branch from 4cf8275 to c7daa00 Compare June 8, 2022 17:29
@Gregory-Pereira Gregory-Pereira force-pushed the enable-sync-job-from-management-api branch from c7daa00 to 614cf1e Compare June 8, 2022 17:34
harshad16
harshad16 approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@harshad16 harshad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks 💯

@sesheta sesheta added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@sesheta
Copy link
Member

sesheta commented Jun 8, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: harshad16
To complete the pull request process, please assign fridex after the PR has been reviewed.
You can assign the PR to them by writing /assign @fridex in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@harshad16 harshad16 merged commit bc61508 into thoth-station:master Jun 10, 2022
@harshad16 harshad16 mentioned this pull request Jul 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fridex fridex fridex left review comments

@harshad16 harshad16 harshad16 approved these changes

@goern goern Awaiting requested review from goern goern is a code owner

Assignees

@harshad16 harshad16

Labels
lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gregory-Pereira @sesheta @fridex @harshad16