forked from actions/toolkit
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] main from actions:main #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pull
wants to merge
425
commits into
threatcode:main
Choose a base branch
from
actions:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use native `crypto` package from node
Properly resolve relative symlinks
Includes: - #1815
Update artifact release notes
Signed-off-by: Brian DeHamer <[email protected]>
Signed-off-by: Brian DeHamer <[email protected]>
Signed-off-by: Brian DeHamer <[email protected]>
`@actions/attest`: bump @sigstore/sign from 2.3.2 to 3.0.0
`@actions/attest`: bump @actions/core from 1.10.1 to 1.11.1
`@actions/attest`: prep release of @actions/attest v1.5.0
When using some monorepo-related tools (like [changesets](https://github.com/changesets/changesets)), the produced tags have a special format that includes `@` character. For example, a `foo` package on a monorepo will produce Git tags looking like `[email protected]` if using changesets. When used in combination with `actions/attest-build-provenance`, the action was not properly re-crafting the tag in `buildSLSAProvenancePredicate` because it was always splitting the workflow ref by `@` and taking the second element. This result in this error on CI: ``` Error: Error: Failed to persist attestation: Invalid Argument - values do not match: refs/tags/foo != refs/tags/[email protected] - https://docs.github.com/rest/repos/repos#create-an-attestation ```` This PR slightly update the logic there, and rather take "everything located after the first '@'". This shouldn't introduce any breaking change, while giving support for custom tags. I've added the corresponding test case, it passes, however I couldn't successfully run the full test suite (neither on `main`). Looking forward for CI outcome. Thanks in advance for the review 🙏.
Signed-off-by: Brian DeHamer <[email protected]>
Signed-off-by: Brian DeHamer <[email protected]>
`@actions/attest`: Support multi-subject attestations
Handle tags containing "@" character in `buildSLSAProvenancePredicate`
Signed-off-by: Brian DeHamer <[email protected]>
`@actions/attest`: Release notes for v1.5.0 release
…to errors - Update isFeatureAvailable() to leverage ACTIONS_CACHE_SERVICE_V2 feature flag - For v2: check ACTIONS_RESULTS_URL availability - For v1: check either ACTIONS_CACHE_URL or ACTIONS_RESULTS_URL availability - Change warning logs to error logs for cache failures - Add comprehensive tests covering all scenarios Co-authored-by: Link- <[email protected]>
- Update restoreCacheV2.test.ts, restoreCache.test.ts, saveCacheV2.test.ts, and saveCache.test.ts - Change test expectations from core.warning to core.error for cache operation failures - All tests now pass successfully Co-authored-by: Link- <[email protected]>
…ailures Co-authored-by: Link- <[email protected]>
Co-authored-by: Link- <[email protected]>
Co-authored-by: Link- <[email protected]>
…n as requested Co-authored-by: Link- <[email protected]>
Co-authored-by: Link- <[email protected]>
Co-authored-by: Link- <[email protected]>
Co-authored-by: Link- <[email protected]>
Explicit logging of cache key and restore key matches
Improve cache service availability determination and implement conditional error logging
Fix typo in `core/README.md`
Move `@protobuf-ts/plugin` to dev dependencies
Prepare `@actions/cache` 4.0.4
Reintroduce `@protobuf-ts/runtime-rpc` as a runtime dependency
Co-authored-by: Copilot <[email protected]>
…to Link-/fix-cache-tests
Update cache package compilation step to only install runtime dependencies
Prepare release `4.0.5`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.3)
Can you help keep this open source service alive? 💖 Please sponsor : )