Introduced authorization decrease change period parameter to the beacon #2960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This value protect against malicious operators who manipulate
their weight by overwriting authorization decrease request, and
lowering or increasing their eligible stake this way.
Authorization decrease change period is the time period before the authorization
decrease delay end, during which the authorization decrease request can be
overwritten.
When the request is overwritten, the authorization decrease delay is
reset.
For example, if `authorizationDecraseChangePeriod` is set to 4
days, `authorizationDecreaseDelay` is set to 14 days, and someone
requested authorization decrease, it means they can not
request another decrease for the first 10 days. After 10 days pass,
they can request again and overwrite the previous authorization
decrease request. The delay time will reset for them and they
will have to wait another 10 days to alter it and 14 days to
approve it.
If set to a value equal to `authorizationDecreaseDelay, it means
that authorization decrease request can be always overwritten.
If set to zero, it means authorization decrease request can not
be overwritten until the delay end, and one needs to wait for the entire
authorization decrease delay to approve their decrease or to alter it.
(1) authorization decrease requested timestamp
(2) from this moment authorization decrease request can be
overwritten
(3) from this moment authorization decrease request can be
approved, assuming it was NOT overwritten in (2)
(1) (2) (3)
--x------------------------------x--------------------------x---->
| \________________________/
| authorizationDecreaseChangePeriod
\______________________________________________________/
authorizationDecreaseDelay
pdyraga
force-pushed
the
authorization-stuff-2
branch
from
b55e656 to
cd5f0da
Compare
|
#2959 got merged so I am undrafting this one |
nkuba
approved these changes
Apr 29, 2022
| // will have to wait another 10 days to alter it and 14 days to | ||
| // approve it. | ||
| // | ||
| // This value protect against malicious operators who manipulate |
There was a problem hiding this comment.
Suggested change
| // This value protect against malicious operators who manipulate | |
| // This value protects against malicious operators who manipulate |
| decreasingBy, | ||
| decreasingAt | ||
| ); | ||
| AuthorizationDecrease storage decreaseRequest = self.pendingDecreases[ |
There was a problem hiding this comment.
Suggested change
| AuthorizationDecrease storage decreaseRequest = self.pendingDecreases[ | |
| AuthorizationDecrease storage pendingDecrease = self.pendingDecreases[ |
| ).to.be.equal(deauthorizingSecond) | ||
| }) | ||
|
|
||
| context("when delay passed", () => { |
There was a problem hiding this comment.
Can we add one more test under "when change period is equal delay" to cover a case where the requestAuthorizationDecrease is called without any increaseTime?
| }) | ||
| }) | ||
|
|
||
| context("when change period is zero", () => { |
There was a problem hiding this comment.
Can we have two test cases under "when change period is zero":
requestAuthorizationDecreaseis called right away without any time increaserequestAuthorizationDecreaseis called after the delay period
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2959See threshold-network/solidity-contracts#99
Introduced authorization decrease change period parameter to the beacon
This value protect against malicious operators who manipulate
their weight by overwriting authorization decrease request, and
lowering or increasing their eligible stake this way.
Authorization decrease change period is the time period before the authorization
decrease delay end, during which the authorization decrease request can be
overwritten.
When the request is overwritten, the authorization decrease delay is
reset.
For example, if
authorizationDecraseChangePeriodis set to 4days,
authorizationDecreaseDelayis set to 14 days, and someonerequested authorization decrease, it means they can not
request another decrease for the first 10 days. After 10 days pass,
they can request again and overwrite the previous authorization
decrease request. The delay time will reset for them and they
will have to wait another 10 days to alter it and 14 days to
approve it.
If set to a value equal to `authorizationDecreaseDelay, it means
that authorization decrease request can be always overwritten.
If set to zero, it means authorization decrease request can not
be overwritten until the delay end, and one needs to wait for the entire
authorization decrease delay to approve their decrease or to alter it.