Skip to content

Conversation

@NeilRashbrook
Copy link
Contributor

I'd like to be able to get all of the metadata from storage at once. One way of doing it would be to drop it along with the cache calendar, since you don't normally have to explicitly fetch it anyway.

@kewisch
Copy link
Member

kewisch commented Dec 5, 2020

I can see why you chose this approach. It gives me some pause though to mix in all the metadata with a request like this, even though there are likely indeed less use cases to retrieve the cached calendar directly. I think I'd feel more comfortable with a separate method.

Also if possible, maybe we can join the keys and values into a single object? This feels more consistent with WebExtension APIs.

@NeilRashbrook
Copy link
Contributor Author

Should this new method be named calendar.provider.getAllMetaData or perhaps something else?

In the mean time I've written the adjustment that returns the metadata as an object with the ids as keys (this code will then be cut and pasted into the new method).

@kewisch
Copy link
Member

kewisch commented Jul 20, 2021

calendar.provider.getAllMetadata sgtm

@NeilRashbrook
Copy link
Contributor Author

Sorry for the delay, I was in hospital. I've now moved the code to a getAllMetadata function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants