Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autolist_package_ids to SchemaCommunity #1039

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

x753
Copy link
Contributor

@x753 x753 commented Jun 6, 2024

The Community Schema now has an autolist_package_ids property, which allows for creating listings for specified packages in the community when the schema is synced.

Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (142abd8) to head (5bdd386).
Report is 37 commits behind head on master.

Files Patch % Lines
django/thunderstore/schema_import/sync.py 14.28% 6 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (142abd8) and HEAD (5bdd386). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (142abd8) HEAD (5bdd386)
6 4
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1039       +/-   ##
===========================================
- Coverage   92.95%   82.49%   -10.47%     
===========================================
  Files         314      314               
  Lines        9070     9098       +28     
  Branches      806      811        +5     
===========================================
- Hits         8431     7505      -926     
- Misses        530     1392      +862     
- Partials      109      201       +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@MythicManiac MythicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, care to add a test case for this as well? There should be a handful of tests for the schema importer already for reference

x753 and others added 2 commits September 5, 2024 17:07
The Community Schema now has an autolist_package_ids property, which allows
for creating listings for specified packages in the community when the schema
is synced.
Add a test case which ensures the ecosystem schema autolisted package
IDs field is imported correctly
@MythicManiac MythicManiac merged commit 39e4f1c into master Sep 5, 2024
24 checks passed
@MythicManiac MythicManiac deleted the autolist-default-packages branch September 5, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants