Skip to content

Kept ids and improvements. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tibi2303 merged 3 commits into from
Jul 1, 2025
Merged

Kept ids and improvements. #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62175e2
Kept ids and improvements.
tibi2303 Jul 1, 2025
c62d95d
Merge branch 'master' into dataset-id-to-id.
tibi2303 Jul 1, 2025
4548cb7
Update tests.
tibi2303 Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions dist/slimselect.cjs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,6 +366,7 @@ class Store {

class Render {
constructor(settings, classes, store, callbacks) {
var _a;
this.store = store;
this.settings = settings;
this.classes = classes;
Expand All @@ -375,7 +376,12 @@ class Render {
this.content = this.contentDiv();
this.updateClassStyles();
this.updateAriaAttributes();
if (this.settings.contentLocation) {
const contentContainer = (_a = document
.querySelector(`[data-id="${this.settings.id}"]`)) === null || _a === void 0 ? void 0 : _a.closest('.offcanvas-body');
if (contentContainer) {
contentContainer.appendChild(this.content.main);
}
else if (this.settings.contentLocation) {
this.settings.contentLocation.appendChild(this.content.main);
}
}
Expand Down Expand Up @@ -415,7 +421,9 @@ class Render {
this.content.main.className = '';
this.content.main.removeAttribute('style');
this.main.main.classList.add(this.classes.main);
this.main.main.classList.add('ss-2');
this.content.main.classList.add(this.classes.content);
this.content.main.classList.add('ss-content-2');
if (this.settings.style !== '') {
this.main.main.style.cssText = this.settings.style;
this.content.main.style.cssText = this.settings.style;
Expand Down Expand Up @@ -443,7 +451,7 @@ class Render {
mainDiv() {
var _a;
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-main';
main.setAttribute('aria-label', this.settings.ariaLabel);
main.tabIndex = 0;
main.onkeydown = (e) => {
Expand Down Expand Up @@ -752,7 +760,7 @@ class Render {
}
contentDiv() {
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-content';
const search = this.searchDiv();
main.appendChild(search.main);
const list = this.listDiv();
Expand Down Expand Up @@ -1160,7 +1168,7 @@ class Render {
return placeholder;
}
const optionEl = document.createElement('div');
optionEl.dataset.id = option.id;
optionEl.id = option.id;
optionEl.classList.add(this.classes.option);
optionEl.setAttribute('role', 'option');
if (option.class) {
Expand Down
2 changes: 1 addition & 1 deletion dist/slimselect.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/slimselect.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 12 additions & 4 deletions dist/slimselect.es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,6 +364,7 @@ class Store {

class Render {
constructor(settings, classes, store, callbacks) {
var _a;
this.store = store;
this.settings = settings;
this.classes = classes;
Expand All @@ -373,7 +374,12 @@ class Render {
this.content = this.contentDiv();
this.updateClassStyles();
this.updateAriaAttributes();
if (this.settings.contentLocation) {
const contentContainer = (_a = document
.querySelector(`[data-id="${this.settings.id}"]`)) === null || _a === void 0 ? void 0 : _a.closest('.offcanvas-body');
if (contentContainer) {
contentContainer.appendChild(this.content.main);
}
else if (this.settings.contentLocation) {
this.settings.contentLocation.appendChild(this.content.main);
}
}
Expand Down Expand Up @@ -413,7 +419,9 @@ class Render {
this.content.main.className = '';
this.content.main.removeAttribute('style');
this.main.main.classList.add(this.classes.main);
this.main.main.classList.add('ss-2');
this.content.main.classList.add(this.classes.content);
this.content.main.classList.add('ss-content-2');
if (this.settings.style !== '') {
this.main.main.style.cssText = this.settings.style;
this.content.main.style.cssText = this.settings.style;
Expand Down Expand Up @@ -441,7 +449,7 @@ class Render {
mainDiv() {
var _a;
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-main';
main.setAttribute('aria-label', this.settings.ariaLabel);
main.tabIndex = 0;
main.onkeydown = (e) => {
Expand Down Expand Up @@ -750,7 +758,7 @@ class Render {
}
contentDiv() {
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-content';
const search = this.searchDiv();
main.appendChild(search.main);
const list = this.listDiv();
Expand Down Expand Up @@ -1158,7 +1166,7 @@ class Render {
return placeholder;
}
const optionEl = document.createElement('div');
optionEl.dataset.id = option.id;
optionEl.id = option.id;
optionEl.classList.add(this.classes.option);
optionEl.setAttribute('role', 'option');
if (option.class) {
Expand Down
16 changes: 12 additions & 4 deletions dist/slimselect.global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@ var SlimSelect = (function () {

class Render {
constructor(settings, classes, store, callbacks) {
var _a;
this.store = store;
this.settings = settings;
this.classes = classes;
Expand All @@ -376,7 +377,12 @@ var SlimSelect = (function () {
this.content = this.contentDiv();
this.updateClassStyles();
this.updateAriaAttributes();
if (this.settings.contentLocation) {
const contentContainer = (_a = document
.querySelector(`[data-id="${this.settings.id}"]`)) === null || _a === void 0 ? void 0 : _a.closest('.offcanvas-body');
if (contentContainer) {
contentContainer.appendChild(this.content.main);
}
else if (this.settings.contentLocation) {
this.settings.contentLocation.appendChild(this.content.main);
}
}
Expand Down Expand Up @@ -416,7 +422,9 @@ var SlimSelect = (function () {
this.content.main.className = '';
this.content.main.removeAttribute('style');
this.main.main.classList.add(this.classes.main);
this.main.main.classList.add('ss-2');
this.content.main.classList.add(this.classes.content);
this.content.main.classList.add('ss-content-2');
if (this.settings.style !== '') {
this.main.main.style.cssText = this.settings.style;
this.content.main.style.cssText = this.settings.style;
Expand Down Expand Up @@ -444,7 +452,7 @@ var SlimSelect = (function () {
mainDiv() {
var _a;
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-main';
main.setAttribute('aria-label', this.settings.ariaLabel);
main.tabIndex = 0;
main.onkeydown = (e) => {
Expand Down Expand Up @@ -753,7 +761,7 @@ var SlimSelect = (function () {
}
contentDiv() {
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-content';
const search = this.searchDiv();
main.appendChild(search.main);
const list = this.listDiv();
Expand Down Expand Up @@ -1161,7 +1169,7 @@ var SlimSelect = (function () {
return placeholder;
}
const optionEl = document.createElement('div');
optionEl.dataset.id = option.id;
optionEl.id = option.id;
optionEl.classList.add(this.classes.option);
optionEl.setAttribute('role', 'option');
if (option.class) {
Expand Down
16 changes: 12 additions & 4 deletions dist/slimselect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@

class Render {
constructor(settings, classes, store, callbacks) {
var _a;
this.store = store;
this.settings = settings;
this.classes = classes;
Expand All @@ -379,7 +380,12 @@
this.content = this.contentDiv();
this.updateClassStyles();
this.updateAriaAttributes();
if (this.settings.contentLocation) {
const contentContainer = (_a = document
.querySelector(`[data-id="${this.settings.id}"]`)) === null || _a === void 0 ? void 0 : _a.closest('.offcanvas-body');
if (contentContainer) {
contentContainer.appendChild(this.content.main);
}
else if (this.settings.contentLocation) {
this.settings.contentLocation.appendChild(this.content.main);
}
}
Expand Down Expand Up @@ -419,7 +425,9 @@
this.content.main.className = '';
this.content.main.removeAttribute('style');
this.main.main.classList.add(this.classes.main);
this.main.main.classList.add('ss-2');
this.content.main.classList.add(this.classes.content);
this.content.main.classList.add('ss-content-2');
if (this.settings.style !== '') {
this.main.main.style.cssText = this.settings.style;
this.content.main.style.cssText = this.settings.style;
Expand Down Expand Up @@ -447,7 +455,7 @@
mainDiv() {
var _a;
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-main';
main.setAttribute('aria-label', this.settings.ariaLabel);
main.tabIndex = 0;
main.onkeydown = (e) => {
Expand Down Expand Up @@ -756,7 +764,7 @@
}
contentDiv() {
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-content';
const search = this.searchDiv();
main.appendChild(search.main);
const list = this.listDiv();
Expand Down Expand Up @@ -1164,7 +1172,7 @@
return placeholder;
}
const optionEl = document.createElement('div');
optionEl.dataset.id = option.id;
optionEl.id = option.id;
optionEl.classList.add(this.classes.option);
optionEl.setAttribute('role', 'option');
if (option.class) {
Expand Down
2 changes: 1 addition & 1 deletion dist/slimselect.min.js
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 12 additions & 4 deletions dist/slimselect.umd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,6 +370,7 @@

class Render {
constructor(settings, classes, store, callbacks) {
var _a;
this.store = store;
this.settings = settings;
this.classes = classes;
Expand All @@ -379,7 +380,12 @@
this.content = this.contentDiv();
this.updateClassStyles();
this.updateAriaAttributes();
if (this.settings.contentLocation) {
const contentContainer = (_a = document
.querySelector(`[data-id="${this.settings.id}"]`)) === null || _a === void 0 ? void 0 : _a.closest('.offcanvas-body');
if (contentContainer) {
contentContainer.appendChild(this.content.main);
}
else if (this.settings.contentLocation) {
this.settings.contentLocation.appendChild(this.content.main);
}
}
Expand Down Expand Up @@ -419,7 +425,9 @@
this.content.main.className = '';
this.content.main.removeAttribute('style');
this.main.main.classList.add(this.classes.main);
this.main.main.classList.add('ss-2');
this.content.main.classList.add(this.classes.content);
this.content.main.classList.add('ss-content-2');
if (this.settings.style !== '') {
this.main.main.style.cssText = this.settings.style;
this.content.main.style.cssText = this.settings.style;
Expand Down Expand Up @@ -447,7 +455,7 @@
mainDiv() {
var _a;
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-main';
main.setAttribute('aria-label', this.settings.ariaLabel);
main.tabIndex = 0;
main.onkeydown = (e) => {
Expand Down Expand Up @@ -756,7 +764,7 @@
}
contentDiv() {
const main = document.createElement('div');
main.dataset.id = this.settings.id;
main.id = this.settings.id + '-content';
const search = this.searchDiv();
main.appendChild(search.main);
const list = this.listDiv();
Expand Down Expand Up @@ -1164,7 +1172,7 @@
return placeholder;
}
const optionEl = document.createElement('div');
optionEl.dataset.id = option.id;
optionEl.id = option.id;
optionEl.classList.add(this.classes.option);
optionEl.setAttribute('role', 'option');
if (option.class) {
Expand Down
2 changes: 1 addition & 1 deletion dist/slimselect.umd.min.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/assets/index.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/assets/index.js
View file
Open in desktop

Large diffs are not rendered by default.

Loading