Skip to content

Improve scroll behaviour for fixed position. #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tibi2303 merged 2 commits into from
Aug 4, 2025
Merged

Improve scroll behaviour for fixed position. #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4fcb3a
Improve scroll behaviour for fixed position.
tibi2303 Jul 23, 2025
0505c79
Build.
tibi2303 Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dist/render.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ export default class Render {
private lastSelectedOption;
main: Main;
content: Content;
private scrollHandler;
private resizeHandler;
classes: CssClasses;
constructor(settings: Required<Settings>, classes: Required<CssClasses>, store: Store, callbacks: Callbacks);
enable(): void;
Expand Down
15 changes: 15 additions & 0 deletions dist/slimselect.cjs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,6 +406,13 @@ class Render {
this.ensureElementInView(this.content.list, selectedOption);
}
}
if (this.settings.contentPosition === 'fixed') {
this.moveContent();
this.scrollHandler = () => this.moveContent();
this.resizeHandler = () => this.moveContent();
window.addEventListener('scroll', this.scrollHandler, true);
window.addEventListener('resize', this.resizeHandler);
}
}
close() {
this.main.main.classList.remove(this.classes.openAbove);
Expand All @@ -414,6 +421,14 @@ class Render {
this.content.main.classList.remove(this.classes.openAbove);
this.content.main.classList.remove(this.classes.openBelow);
this.main.arrow.path.setAttribute('d', this.classes.arrowClose);
if (this.scrollHandler) {
window.removeEventListener('scroll', this.scrollHandler, true);
this.scrollHandler = undefined;
}
if (this.resizeHandler) {
window.removeEventListener('resize', this.resizeHandler);
this.resizeHandler = undefined;
}
}
updateClassStyles() {
this.main.main.className = '';
Expand Down
15 changes: 15 additions & 0 deletions dist/slimselect.es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,6 +404,13 @@ class Render {
this.ensureElementInView(this.content.list, selectedOption);
}
}
if (this.settings.contentPosition === 'fixed') {
this.moveContent();
this.scrollHandler = () => this.moveContent();
this.resizeHandler = () => this.moveContent();
window.addEventListener('scroll', this.scrollHandler, true);
window.addEventListener('resize', this.resizeHandler);
}
}
close() {
this.main.main.classList.remove(this.classes.openAbove);
Expand All @@ -412,6 +419,14 @@ class Render {
this.content.main.classList.remove(this.classes.openAbove);
this.content.main.classList.remove(this.classes.openBelow);
this.main.arrow.path.setAttribute('d', this.classes.arrowClose);
if (this.scrollHandler) {
window.removeEventListener('scroll', this.scrollHandler, true);
this.scrollHandler = undefined;
}
if (this.resizeHandler) {
window.removeEventListener('resize', this.resizeHandler);
this.resizeHandler = undefined;
}
}
updateClassStyles() {
this.main.main.className = '';
Expand Down
15 changes: 15 additions & 0 deletions dist/slimselect.global.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,6 +407,13 @@ var SlimSelect = (function () {
this.ensureElementInView(this.content.list, selectedOption);
}
}
if (this.settings.contentPosition === 'fixed') {
this.moveContent();
this.scrollHandler = () => this.moveContent();
this.resizeHandler = () => this.moveContent();
window.addEventListener('scroll', this.scrollHandler, true);
window.addEventListener('resize', this.resizeHandler);
}
}
close() {
this.main.main.classList.remove(this.classes.openAbove);
Expand All @@ -415,6 +422,14 @@ var SlimSelect = (function () {
this.content.main.classList.remove(this.classes.openAbove);
this.content.main.classList.remove(this.classes.openBelow);
this.main.arrow.path.setAttribute('d', this.classes.arrowClose);
if (this.scrollHandler) {
window.removeEventListener('scroll', this.scrollHandler, true);
this.scrollHandler = undefined;
}
if (this.resizeHandler) {
window.removeEventListener('resize', this.resizeHandler);
this.resizeHandler = undefined;
}
}
updateClassStyles() {
this.main.main.className = '';
Expand Down
15 changes: 15 additions & 0 deletions dist/slimselect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,13 @@
this.ensureElementInView(this.content.list, selectedOption);
}
}
if (this.settings.contentPosition === 'fixed') {
this.moveContent();
this.scrollHandler = () => this.moveContent();
this.resizeHandler = () => this.moveContent();
window.addEventListener('scroll', this.scrollHandler, true);
window.addEventListener('resize', this.resizeHandler);
}
}
close() {
this.main.main.classList.remove(this.classes.openAbove);
Expand All @@ -418,6 +425,14 @@
this.content.main.classList.remove(this.classes.openAbove);
this.content.main.classList.remove(this.classes.openBelow);
this.main.arrow.path.setAttribute('d', this.classes.arrowClose);
if (this.scrollHandler) {
window.removeEventListener('scroll', this.scrollHandler, true);
this.scrollHandler = undefined;
}
if (this.resizeHandler) {
window.removeEventListener('resize', this.resizeHandler);
this.resizeHandler = undefined;
}
}
updateClassStyles() {
this.main.main.className = '';
Expand Down
2 changes: 1 addition & 1 deletion dist/slimselect.min.js
View file
Open in desktop

Large diffs are not rendered by default.

15 changes: 15 additions & 0 deletions dist/slimselect.umd.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,6 +410,13 @@
this.ensureElementInView(this.content.list, selectedOption);
}
}
if (this.settings.contentPosition === 'fixed') {
this.moveContent();
this.scrollHandler = () => this.moveContent();
this.resizeHandler = () => this.moveContent();
window.addEventListener('scroll', this.scrollHandler, true);
window.addEventListener('resize', this.resizeHandler);
}
}
close() {
this.main.main.classList.remove(this.classes.openAbove);
Expand All @@ -418,6 +425,14 @@
this.content.main.classList.remove(this.classes.openAbove);
this.content.main.classList.remove(this.classes.openBelow);
this.main.arrow.path.setAttribute('d', this.classes.arrowClose);
if (this.scrollHandler) {
window.removeEventListener('scroll', this.scrollHandler, true);
this.scrollHandler = undefined;
}
if (this.resizeHandler) {
window.removeEventListener('resize', this.resizeHandler);
this.resizeHandler = undefined;
}
}
updateClassStyles() {
this.main.main.className = '';
Expand Down
2 changes: 1 addition & 1 deletion dist/slimselect.umd.min.js
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions docs/assets/index.js
View file
Open in desktop

Large diffs are not rendered by default.

23 changes: 23 additions & 0 deletions src/slim-select/render.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,9 @@ export default class Render {
public main: Main
public content: Content

private scrollHandler: (() => void) | undefined;
private resizeHandler: (() => void) | undefined;

// Classes
public classes: CssClasses

Expand Down Expand Up @@ -123,6 +126,16 @@ export default class Render {
this.ensureElementInView(this.content.list, selectedOption)
}
}
if (this.settings.contentPosition === 'fixed') {
this.moveContent();

// Instant (non-debounced) handlers
this.scrollHandler = () => this.moveContent();
this.resizeHandler = () => this.moveContent();

window.addEventListener('scroll', this.scrollHandler, true); // capture phase
window.addEventListener('resize', this.resizeHandler);
}
}

public close(): void {
Expand All @@ -132,6 +145,16 @@ export default class Render {
this.content.main.classList.remove(this.classes.openAbove)
this.content.main.classList.remove(this.classes.openBelow)
this.main.arrow.path.setAttribute('d', this.classes.arrowClose)

if (this.scrollHandler) {
window.removeEventListener('scroll', this.scrollHandler, true);
this.scrollHandler = undefined;
}

if (this.resizeHandler) {
window.removeEventListener('resize', this.resizeHandler);
this.resizeHandler = undefined;
}
}

public updateClassStyles(): void {
Expand Down