[QAE-456] Simple bolus calculator element updates #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Foscottl-TP
changed the title
Petr-Zywczok
requested changes
Apr 10, 2025
Changed bolusEntryTextField so it will support SImple Bolus Calulator and Bolus screens. Both Current Glucose and Bolus fields use the same identifier so rather than the default value determining the correct field, a supporting extension in Base Screen was added to help distinguish the the two. This can be used for parsing similar situations in future test cases.
Changed bolusEntryTextField so it will support SImple Bolus Calulator and Bolus screens. Both Current Glucose and Bolus fields use the same identifier so rather than the default value determining the correct field, a supporting extension in Base Screen was added to help distinguish the the two. This can be used for parsing similar situations in future test cases.
HomeScreen push was updated before updating with current build. This is to undo the previous commit.
Changing the Label names to see if this will work in application rather than using the first/last match method
Testing again if the bolus and current glucose field can be separately defined other than dissmissablekeyboardtextfield.
Updated text field query for Current Glucose and Bolus elements
Yet another attempt to pull duplicate identifier fields
Buckled and just added accesibilityIdentifier to each element...
Added Action to get the bolus field value. Needed for verifying if the value is reset when the current glucose field is edited.
Foscottl-TP
force-pushed
the
scott/QAE-456-SimpleBolusCalculator-MinandMaxGlucos
branch
from
1c9bcb8 to
bc0011a
Compare
Updated to corrent naming conventions
Fixed the spacing formatting issue on a Base Screen function and changed the label of the glucose EntryOutOfRangeWarning to match an identifier already present.
What the summary says
Fixed incorrect field name
Used to support the optional in verification: "Then x field displays value x" (New Bolus steps addition)
Reverted Capitalization and added Carbohydrates
Removed element and verification because it is no longer used due to suggested change in LoopSupport
Petr-Zywczok
approved these changes
Apr 22, 2025
|
|
||
|
|
||
| public func getPumpPillValue() -> String { hudPumpPill.getValueSafe() } | ||
| public func getHudGlucosePill() -> String { hudGlucosePill.getValueSafe()} |
There was a problem hiding this comment.
Suggested change
| public func getHudGlucosePill() -> String { hudGlucosePill.getValueSafe()} | |
| public func getHudGlucosePill() -> String { hudGlucosePill.getValueSafe() } |
| @@ -41,6 +52,7 @@ public final class BolusScreen: BaseScreen { | |||
| } | |||
|
|
|||
| public func setBolusEntryTextField(value: String) { bolusEntryTextField.typeText(value) } | |||
| public func setCurrentGlucoseEntryTextField(value: String) { currentGlucoseEntryTextField.typeText(value)} | |||
There was a problem hiding this comment.
Suggested change
| public func setCurrentGlucoseEntryTextField(value: String) { currentGlucoseEntryTextField.typeText(value)} | |
| public func setCurrentGlucoseEntryTextField(value: String) { currentGlucoseEntryTextField.typeText(value) } |
| @@ -25,9 +27,18 @@ public final class BolusScreen: BaseScreen { | |||
| public var getBolusActionButtonLabel: String { bolusActionButton.getLableSafe() } | |||
|
|
|||
| public func tapCancelBolusButton() { bolusCancelButton.safeTap() } | |||
| public func tapCurrentGlucoseEntryTextField() {currentGlucoseEntryTextField.safeTap()} | |||
There was a problem hiding this comment.
Suggested change
| public func tapCurrentGlucoseEntryTextField() {currentGlucoseEntryTextField.safeTap()} | |
| public func tapCurrentGlucoseEntryTextField() { currentGlucoseEntryTextField.safeTap() } |
Comment on lines
15
to
17
| private var currentGlucoseEntryTextField: XCUIElement { app.textFields["textField_CurrentGlucose"]} | ||
| private var bolusEntryTextField: XCUIElement { app.textFields["textField_Bolus"]} | ||
| private var carbohydratesTextField: XCUIElement { app.textFields["textField_Carbohydrates"]} |
There was a problem hiding this comment.
Suggested change
| private var currentGlucoseEntryTextField: XCUIElement { app.textFields["textField_CurrentGlucose"]} | |
| private var bolusEntryTextField: XCUIElement { app.textFields["textField_Bolus"]} | |
| private var carbohydratesTextField: XCUIElement { app.textFields["textField_Carbohydrates"]} | |
| private var currentGlucoseEntryTextField: XCUIElement { app.textFields["textField_CurrentGlucose"] } | |
| private var bolusEntryTextField: XCUIElement { app.textFields["textField_Bolus"] } | |
| private var carbohydratesTextField: XCUIElement { app.textFields["textField_Carbohydrates"] } |
Removed element and verification because it is no longer used due to suggested change in LoopSupport
…ttps://github.com/tidepool-org/LoopUITestingKit into scott/QAE-456-SimpleBolusCalculator-MinandMaxGlucos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added multiple elements in support of the Simple Bolus Calculator test case automation