clinic sites #159
Open
clinic sites #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gniezen any guidance on how to check up on these failures? I don't seem to be able to log in to redocly. Have I missed some instructions somewhere? |
ewollesen
force-pushed
the
eric-sites
branch
2 times, most recently
from
ac17368 to
9e787bc
Compare
|
|
@ewollesen We only have three seats for Redocly at the moment, but it seems they automatically add all repo participants when there's a new PR, so the error was that we're exceeding the seat limit. Let's ignore Redocly errors for now, and I'll work with @tjotala to get it sorted when he's back. |
ewollesen
force-pushed
the
eric-sites
branch
2 times, most recently
from
252debc to
2548f50
Compare
lostlevels
previously approved these changes
Jun 16, 2025
|
@lostlevels I had to rebase onto the latest master, which included the redocly changes, so unfortunately it's kinda a lot of little changes. No logical/functional changes were intended. Just a lot of renaming to match and YAML formatting changes. |
lostlevels
previously approved these changes
Jun 26, 2025
toddkazakov
previously approved these changes
Aug 14, 2025
toddkazakov
approved these changes
Aug 15, 2025
Update: re-based on top of the redocly changes.
Update: re-based on top of changes to remove ordering facility
matching
BACK-3634
After discussion with the team, we will: - no longer have a GET endpoint to list clinic sites - sites creation/update/deletion will no longer return a list of sites - site creation/update will return only the affected site BACK-3632
After discussion with the team, we will: - no longer have a GET endpoint to list patient tags - patient tags creation/update/deletion will no longer return a list of tags - patient tags creation/update will return only the affected tag BACK-3632
The requirement for having patient counts in the returned sites was removed, and since the implementation was clunky, removing it for now seems optimal. BACK-3632
toddkazakov
previously approved these changes
Aug 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BACK-3634
REMINDER the backend change to return a 204 on deletion of a site requires a matching frontend change. Deploying to prod without the matching frontend change will break the frontend!