[WEB-4592] Fix patient list stale-overwrite race under slow network - #1929
Merged
Conversation
When multiple fetchPatientsForClinic dispatches are in flight simultaneously, an older response arriving last would overwrite the newer one's correctly-filtered result, then flipping to the unfiltered set.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a stale-overwrite race in the clinic patients fetch flow by ensuring that when multiple fetchPatientsForClinic requests are in flight, only the most recently-dispatched request is allowed to update Redux state.
Changes:
- Add a monotonic request sequence guard to
fetchPatientsForClinicto ignore stale success/failure callbacks. - Add unit tests covering stale success and stale failure response abandonment behavior.
- Bump package version from
1.95.3-rc.1to1.95.3-rc.2.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
app/redux/actions/async.js |
Introduces a request sequence counter to abandon stale getPatientsForClinic responses. |
test/unit/redux/actions/async.test.js |
Adds regression tests ensuring stale responses don’t dispatch SUCCESS/FAILURE. |
package.json |
Increments release candidate version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
henry-tp
approved these changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WEB-4592 Fix patient list stale-overwrite race under slow network
When multiple fetchPatientsForClinic dispatches are in flight
simultaneously, an older response arriving last would overwrite the
newer one's correctly-filtered result, then flipping to the unfiltered
set.