use a default timeout on requests that don't specify one#867
Open
use a default timeout on requests that don't specify one#867
Conversation
ewollesen
force-pushed
the
eric-default-timeout
branch
from
aa189d4 to
d788046
Compare
This behavior was inadvertently lost in e282fb3, but is restored here, while still allowing for per-request timeouts to be specified.
ewollesen
force-pushed
the
eric-default-timeout
branch
from
d788046 to
be3176f
Compare
darinkrauss
reviewed
Feb 26, 2026
Contributor
darinkrauss
left a comment
darinkrauss
left a comment
There was a problem hiding this comment.
I think we can probably abandoned this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This behavior was inadvertently lost in
e282fb3, but is restored here, while
still allowing for per-request timeouts to be specified.