WEB-3418 - Use Redirect instead of Pop-up when connecting Provider on Mobile #447
Conversation
| import InfoIcon from './assets/info-outline-24-px.svg'; | ||
| import CollapseIconOpen from './assets/expand-more-24-px.png'; | ||
| import CollapseIconClose from './assets/chevron-right-24-px.png'; | ||
| import InfoIcon from './assets/info-outline-24-px.png'; |
There was a problem hiding this comment.
See this comment: https://github.com/tidepool-org/blip/pull/1540/files#r2010755798
This is the "before" state after a redirect: https://github.com/user-attachments/assets/f6d02164-da07-4470-ae02-acf4328248c9
There was a problem hiding this comment.
This is fine, though I think we should remove the svg icons, and update any other uses to use the png just to keep things simple/consistent.
I think it's only the info-outline icon that's reused, but you'll need to check.
There was a problem hiding this comment.
Sounds good, removed. I checked and there are no more references to .svgs so I think we're good. I'm also a fan of SVGs over PNGs in general, this is just a weird one.
henry-tp
changed the title
henry-tp
changed the title
| import InfoIcon from './assets/info-outline-24-px.svg'; | ||
| import CollapseIconOpen from './assets/expand-more-24-px.png'; | ||
| import CollapseIconClose from './assets/chevron-right-24-px.png'; | ||
| import InfoIcon from './assets/info-outline-24-px.png'; |
There was a problem hiding this comment.
This is fine, though I think we should remove the svg icons, and update any other uses to use the png just to keep things simple/consistent.
I think it's only the info-outline icon that's reused, but you'll need to check.
WEB-3418
Associated with tidepool-org/blip#1540