feat(ios, android): add new API's, fix existing API's #261

hansemannn · 2019-03-11T22:51:21Z

All changes are in parity with https://github.com/hansemannn/titanium-googlemaps.

Android:

Add poiclick event
Add containsCoordinate method
Add geometryContainsLocation method
Add geometryDistanceBetweenPoints method
Support encoded polylines in Polyline.points
Fix showAnnotations to handle multiple annotations at once
Fix padding property
Fix crash in overlay click events

iOS:

Refactor source (use TitaniumKit imports, remove Xcode 9 guards)
Add containsCoordinate method
Fix padding property

build · 2019-08-31T15:39:37Z

	Fails
🚫	version bump was Major in ios/manifest but None in package.json
🚫	`npm run lint` failed, please check messages below for output.

	Warnings
⚠️	SDK version declared in Jenkinsfile (9.0.0.v20200207060625) does not match iOS' titanium.xcconfig value (9.0.2.GA)
⚠️	🔍 Can't find junit reports at `./TESTS-*.xml`, skipping generating JUnit Report.

Messages

📖

💣 Here's the output of npm run lint:

> @titanium-sdk/[email protected] lint
> npm run lint:android && npm run lint:ios && npm run lint:js && npm run lint:docs


> @titanium-sdk/[email protected] lint:android
> clang-format-lint android/src/**/*.java

Error: Formatting incorrect on "android/src/ti/map/MapModule.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='7134' length='1'>&#10;								   </replacement>
<replacement offset='7558' length='0'>&#10;									 </replacement>
<replacement offset='7681' length='0'> </replacement>
<replacement offset='7813' length='0'> </replacement>
<replacement offset='7904' length='1'>&#10;								   </replacement>
<replacement offset='8033' length='4'>&#10;&#10;	</replacement>
<replacement offset='8395' length='1'>&#10;									  </replacement>
<replacement offset='8553' length='1'>&#10;									  </replacement>
<replacement offset='8761' length='1'>&#10;								 </replacement>
<replacement offset='8771' length='8'>&#10;&#10;		</replacement>
</replacements>

Error: Formatting incorrect on "android/src/ti/map/PolygonProxy.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='4980' length='3'>&#10;			</replacement>
<replacement offset='5040' length='2'> </replacement>
</replacements>

Error: Formatting incorrect on "android/src/ti/map/PolylineProxy.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='1135' length='0'>&#10;</replacement>
<replacement offset='1196' length='5'>&#10;	  </replacement>
<replacement offset='1288' length='12'>&#10;							</replacement>
<replacement offset='1375' length='12'>&#10;							</replacement>
<replacement offset='1457' length='12'>&#10;							</replacement>
<replacement offset='3182' length='6'>&#10;&#10;		</replacement>
<replacement offset='6898' length='3'>&#10;			</replacement>
<replacement offset='6958' length='2'> </replacement>
<replacement offset='8928' length='6'>&#10;												</replacement>
<replacement offset='9115' length='6'>&#10;												</replacement>
</replacements>

Error: Formatting incorrect on "android/src/ti/map/TiUIMapView.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='2997' length='1'>&#10;			   </replacement>
<replacement offset='3050' length='16'> </replacement>
<replacement offset='7420' length='6'>&#10;&#10;		</replacement>
<replacement offset='7930' length='6'>&#10;&#10;		</replacement>
<replacement offset='8039' length='6'>&#10;&#10;		</replacement>
<replacement offset='15521' length='3'>&#10;	</replacement>
<replacement offset='24420' length='1'></replacement>
<replacement offset='24451' length='1'></replacement>
<replacement offset='24457' length='4'>&#10;&#10;	</replacement>
<replacement offset='24525' length='1'>&#10;	</replacement>
<replacement offset='25929' length='1'></replacement>
<replacement offset='25960' length='1'></replacement>
<replacement offset='28362' length='1'>&#10;	</replacement>
<replacement offset='28385' length='5'>&#10;			</replacement>
<replacement offset='28407' length='6'>&#10;&#10;		</replacement>
<replacement offset='28518' length='1'>&#10;			</replacement>
<replacement offset='28627' length='6'>&#10;&#10;		</replacement>
<replacement offset='42386' length='1'>&#10;	</replacement>
<replacement offset='42426' length='6'>&#10;&#10;		</replacement>
<replacement offset='42686' length='6'>&#10;&#10;		</replacement>
<replacement offset='42868' length='6'>&#10;&#10;		</replacement>
</replacements>

Error: Formatting incorrect on "android/src/ti/map/ViewProxy.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='1877' length='1'>&#10;							</replacement>
<replacement offset='1910' length='8'> </replacement>
<replacement offset='10200' length='0'> </replacement>
<replacement offset='10241' length='9'>&#10;&#10;			</replacement>
<replacement offset='13003' length='3'>&#10;	</replacement>
<replacement offset='13279' length='3'>&#10;	</replacement>
<replacement offset='27139' length='4'>&#10;&#10;	</replacement>
<replacement offset='27503' length='1'>&#10;							   </replacement>
<replacement offset='27638' length='1'>&#10;							   </replacement>
<replacement offset='27824' length='0'> </replacement>
<replacement offset='32148' length='4'>&#10;		</replacement>
<replacement offset='32199' length='4'>&#10;&#10;	</replacement>
<replacement offset='32265' length='1'>&#10;	</replacement>
<replacement offset='32267' length='4'>&#10;		</replacement>
<replacement offset='32298' length='4'>&#10;		</replacement>
<replacement offset='32338' length='3'>&#10;			</replacement>
<replacement offset='32362' length='0'> </replacement>
<replacement offset='32399' length='4'>&#10;		</replacement>
<replacement offset='32404' length='4'>&#10;		</replacement>
</replacements>

Generated by 🚫 dangerJS against 614927d

…into add-poi-click

to be able to listen to the location updated immediately after granting the permission instead of closing and reopening the current view

# Conflicts: # android/src/ti/map/TiUIMapView.java

…add-poi-click # Conflicts: # android/build.gradle # ios/titanium.xcconfig

…into add-poi-click

all credits to tidev#446 !

all credits to https://github.com/appcelerator-modules/ti.map/pull/424/files

# Conflicts: # android/build.gradle # android/manifest # android/src/ti/map/MapModule.java

# Conflicts: # android/src/ti/map/MapModule.java

Fixes: Uncaught Error: Could not copy bitmap to parcel blob.

* feat: use fragment container and add raw map mode * feat(android): implement liteMode Fixes MOD-2587 * fix: enable lite mode * chore: remove unused code * fix: remove unused file --------- Co-authored-by: Chris Williams <[email protected]> Co-authored-by: Hans Knöchel <[email protected]>

m1ga · 2023-05-31T18:50:46Z

@janvennemann you can run npm run lint to make dangerJS happy 😄

* feat(android): add “customIcon” property * chore: guard label

apidoc/View.yml

* fix: only ignore tilt and bearing in lite mode * fix: zoom out if markers are out of view * chore: remove debug log

hansemannn · 2023-06-02T17:50:25Z

@m1ga Thx! Unfortunately, the linting does not seem to work:

> @titanium-sdk/[email protected] lint:android
> clang-format-lint android/src/**/*.java

TypeError: Cannot read properties of undefined (reading 'stdout')

m1ga · 2023-06-02T17:54:19Z

@hansemannn sorry, it's npm run format to fix the linting. npm run lint is just to check it again

hansemannn added 3 commits March 11, 2019 23:49

feat(android): add „poiclick“ event

6b22c99

fix: add poi-click listener to map instance

5e6f870

fix: fix null-check in MapView#zoom

bf2373e

hansemannn force-pushed the add-poi-click branch from 7e29149 to bf2373e Compare August 2, 2019 08:52

hansemannn added 4 commits August 3, 2019 00:09

fix: add „conatinsCoordinate“ method for parity

7cef29e

refactor: remove old xcode version guards

2a2ba17

refactor: use TitaniumKit imports, fix all warnings and leaks

fd5a51c

chore: remove old build scripts, require SDK 8

8c07870

hansemannn changed the title ~~feat(android): add „poiclick“ event~~ feat(ios, android): add „poiclick“ event, refactor iOS Aug 31, 2019

Merge branch 'master' into add-poi-click

91a76f2

hansemannn changed the title ~~feat(ios, android): add „poiclick“ event, refactor iOS~~ feat(ios, android): add new API's, fix existing API's Nov 2, 2019

hansemannn and others added 6 commits November 2, 2019 09:56

Merge branch 'master' into add-poi-click

a0c6cda

feat: add containsCoordinate method

67816d6

build: replace maps utils with latest version

7888c77

feat(android): add new API’s

db1582a

Merge branch 'add-poi-click' of https://github.com/hansemannn/ti.map …

fac8c27

…into add-poi-click

fix: use current activity for permission check

7bc0632

to be able to listen to the location updated immediately after granting the permission instead of closing and reopening the current view

hansemannn force-pushed the add-poi-click branch from 4b3f138 to 7bc0632 Compare February 28, 2020 11:06

hansemannn and others added 11 commits February 28, 2020 12:07

chore(ios): expose mapType

4c94feb

refactor(android): use new „OnPolylineClickListener“

409d4ce

# Conflicts: # android/src/ti/map/TiUIMapView.java

Merge branch 'master' of github.com:appcelerator-modules/ti.map into …

ade2bcc

…add-poi-click # Conflicts: # android/build.gradle # ios/titanium.xcconfig

chore: bump version

d5259bb

fix: remove unused aar

57d57d6

feat: add geodesic support

8c306c3

Merge branch 'master' into add-poi-click

7eabf4a

chore: use latest dependencies

8542fbf

fix: fix imports

2380d12

feat: support encoded polylines

a300247

Merge branch 'add-poi-click' of https://github.com/hansemannn/ti.map …

b6adf41

…into add-poi-click

fix(android): pass zoom level to region changed event

09c3510

m1ga mentioned this pull request Oct 2, 2020

feat(android): Update android-maps-utils #336

Merged

hansemannn and others added 9 commits October 26, 2020 11:59

feat(android): add „drawRoundedPolylineBetweenCoordinates“ method

7992bc0

chore: allow “userLocation: true” with “ACCESS_COARSE_LOCATION”

64aa434

fix: fix brackets

033e7f5

fix: guard proxy

26015f5

all credits to tidev#446 !

fix(android): guard markers

150a3f7

all credits to https://github.com/appcelerator-modules/ti.map/pull/424/files

chore: migrate from MKPinAnnotationView

121d567

fix: guard markers to prevent uncaught exceptions

167fafa

fix: add null check

c3d2864

chore: add try-catch block

fd20292

hansemannn mentioned this pull request Feb 3, 2022

feat(ios, android): add new API's, fix existing API's (merge conflicts solved) #519

Closed

1 task

m1ga and others added 9 commits February 23, 2022 16:21

feat(android): use new map api

e239ca9

# Conflicts: # android/build.gradle # android/manifest # android/src/ti/map/MapModule.java

lint

0cdf29d

optimize imports, update map utils

57f2de9

# Conflicts: # android/src/ti/map/MapModule.java

update library

70ae877

fix: fix merge conflicts

614927d

chore: update libraries

58d657e

fix: add “ready” event again

3b2383b

fix: guard invalid blob creation

0325e1f

Fixes: Uncaught Error: Could not copy bitmap to parcel blob.

feat(android): add “customIcon” property (#3)

586334d

* feat(android): add “customIcon” property * chore: guard label

m1ga reviewed Jun 2, 2023

View reviewed changes

apidoc/View.yml Outdated Show resolved Hide resolved

janvennemann and others added 2 commits June 2, 2023 18:18

fix: only ignore tilt and bearing in lite mode (#2)

1862757

* fix: only ignore tilt and bearing in lite mode * fix: zoom out if markers are out of view * chore: remove debug log

fix: fix typo

3a6566a

hansemannn added 2 commits June 5, 2023 10:19

chore: pass font props, fix y-alignment

86de79c

chore(android): add idle event for parity

5e6bc38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(ios, android): add new API's, fix existing API's #261

feat(ios, android): add new API's, fix existing API's #261

Uh oh!

hansemannn commented Mar 11, 2019 •

edited

Loading

Uh oh!

build commented Aug 31, 2019 •

edited

Loading

Uh oh!

m1ga commented May 31, 2023

Uh oh!

Uh oh!

hansemannn commented Jun 2, 2023

Uh oh!

m1ga commented Jun 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

feat(ios, android): add new API's, fix existing API's #261

Are you sure you want to change the base?

feat(ios, android): add new API's, fix existing API's #261

Uh oh!

Conversation

hansemannn commented Mar 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

build commented Aug 31, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

m1ga commented May 31, 2023

Uh oh!

Uh oh!

hansemannn commented Jun 2, 2023

Uh oh!

m1ga commented Jun 2, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

hansemannn commented Mar 11, 2019 •

edited

Loading

build commented Aug 31, 2019 •

edited

Loading