Skip to content

Commit 045a507

Browse files
FvDfrans-ixpantiatopepo
authored
Adds documentation about racing metrics (#128)
* Fixes #113 * updated tests (due to RNG differences) * small updates --------- Co-authored-by: Frans van Dunné <frans@ixpantia.com> Co-authored-by: ‘topepo’ <mxkuhn@gmail.com>
1 parent 0f3d249 commit 045a507

6 files changed

Lines changed: 12 additions & 6 deletions

File tree

R/tune_race_anova.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,8 @@
1919
#' data frame should have columns for each parameter being tuned and rows for
2020
#' tuning parameter candidates. An integer denotes the number of candidate
2121
#' parameter sets to be created automatically.
22-
#' @param metrics A [yardstick::metric_set()] or `NULL`.
22+
#' @param metrics A [yardstick::metric_set()] or `NULL`. The first metric in
23+
#' metrics is the one that will be optimized.
2324
#' @param eval_time A numeric vector of time points where dynamic event time
2425
#' metrics should be computed (e.g. the time-dependent ROC curve, etc). The
2526
#' values must be non-negative and should probably be no greater than the

R/tune_race_win_loss.R

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@
5151
#' statistical analysis is updated. More candidate parameters may be excluded
5252
#' with each new resample that is processed.
5353
#'
54-
#' The [control_race()] function contains are parameter for the significance cutoff
54+
#' The [control_race()] function contains parameters for the significance cutoff
5555
#' applied to the Bradley-Terry model results as well as other relevant arguments.
56+
#' The first metric in the `metrics` argument is the one that will be optimized.
5657
#'
5758
#' ## Censored regression models
5859
#'

inst/WORDLIST

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@ Codecov
55
Lifecycle
66
ORCID
77
PBC
8+
ROR
89
Technometrics
910
doi
1011
dplyr
@@ -18,4 +19,3 @@ suboptimal
1819
tibble
1920
tidymodels
2021
unsummarized
21-
wc

man/tune_race_anova.Rd

Lines changed: 2 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/tune_race_win_loss.Rd

Lines changed: 4 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

tests/testthat/test-win-loss-overall.R

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ test_that("one player is really bad", {
8989
add_model(rf_spec)
9090

9191
grid <- tibble(trees = c(1, 200))
92+
9293
ctrl <- control_race(burn_in = 2, alpha = .05, randomize = TRUE)
9394
set.seed(3355)
9495
tuning_results <- tune_race_win_loss(

0 commit comments

Comments
 (0)