Fix slice #111
Fix slice #111
Conversation
…ameter for grouping. Implement is_range_slice_ungrouped_detected to handle range slices on ungrouped data, with corresponding tests to ensure correct behavior. issue: #53
….by parameter for range slices on ungrouped data.
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the .by parameter in the slice() method for SummarizedExperiment objects and implements detection of ungrouped range slices to provide better error messages. The changes also update GitHub repository URLs and increment the package version.
Key Changes
- Adds
.byparameter support to theslice()method to enable per-operation grouping - Implements
is_range_slice_ungrouped_detected()to detect and prevent range slicing on ungrouped data with helpful error messages - Updates GitHub repository references from
stemangiola/tidySummarizedExperimenttotidyomics/tidySummarizedExperiment
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-is_range_slice_detected.R | Comprehensive test suite for range slice detection and .by parameter handling |
| man/tidySummarizedExperiment-package.Rd | Updated GitHub repository URLs to tidyomics organization |
| man/slice.Rd | Added .by parameter documentation to slice method signature |
| R/utilities.R | Implemented range slice detection logic and enhanced simulate_feature_sample_from_tibble() to support grouping columns |
| R/dplyr_methods.R | Updated slice.SummarizedExperiment() to accept and pass through .by parameter |
| DESCRIPTION | Version bump to 1.19.8 and RoxygenNote update to 7.3.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Refactor is_range_slice_ungrouped_detected function to accept .data as the first argument for improved clarity. Update corresponding tests to reflect argument order change and ensure correct functionality with various input scenarios.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
No description provided.