Skip to content

fix problems during ribbon data sort #3235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasp85 merged 2 commits into from
Apr 30, 2019
Merged

fix problems during ribbon data sort #3235

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab78539
fix problems during ribbon data sort
thomasp85 Apr 11, 2019
e339764
Update R/geom-ribbon.r
thomasp85 Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion R/geom-ribbon.r
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,12 @@ GeomRibbon <- ggproto("GeomRibbon", Geom,
required_aes = c("x", "ymin", "ymax"),

setup_data = function(data, params) {
transform(data[order(data$PANEL, data$group, data$x), ], y = ymin)
if (is.null(data$ymin) && is.null(data$ymax)) {
stop("Either ymin or ymax must be given as an aesthetic", call. = FALSE)
}
data <- data[order(data$PANEL, data$group, data$x), , drop = FALSE]
data$y <- data$ymin %||% data$ymax
data
},

draw_key = draw_key_polygon,
Expand Down