vectorise the font_descent function to allow multiple input#3237
Merged
thomasp85 merged 1 commit intotidyverse:masterfrom Apr 12, 2019
Merged
vectorise the font_descent function to allow multiple input#3237thomasp85 merged 1 commit intotidyverse:masterfrom
thomasp85 merged 1 commit intotidyverse:masterfrom
Conversation
|
This old issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with reprex) and link to this issue. https://reprex.tidyverse.org/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reverse dependency check catched an instance of an extension storing multiple font settings in a title element, which broke the
font_descent()assumption about only being provided a single setting to calculate descent on. This PR vectorises the function and mitigate the revdep break